Skip to content

Commit 2f4a4cc

Browse files
committed
Remove unused basic attribute on trigger build
1 parent f6724a6 commit 2f4a4cc

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

readthedocs/core/utils/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def cname_to_slug(host):
7575
return slug
7676

7777

78-
def trigger_build(project, version=None, record=True, force=False, basic=False):
78+
def trigger_build(project, version=None, record=True, force=False):
7979
"""
8080
Trigger build for project and version.
8181
@@ -97,7 +97,6 @@ def trigger_build(project, version=None, record=True, force=False, basic=False):
9797
version_pk=version.pk,
9898
record=record,
9999
force=force,
100-
basic=basic,
101100
)
102101

103102
build = None

readthedocs/projects/views/private.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,10 +231,9 @@ def done(self, form_list, **kwargs):
231231
for field, value in list(form_data.items()):
232232
if field in extra_fields:
233233
setattr(project, field, value)
234-
basic_only = True
235234
project.save()
236235
project_import.send(sender=project, request=self.request)
237-
trigger_build(project, basic=basic_only)
236+
trigger_build(project)
238237
return HttpResponseRedirect(
239238
reverse('projects_detail', args=[project.slug]))
240239

@@ -271,7 +270,7 @@ def get(self, request, *args, **kwargs):
271270
if form.is_valid():
272271
project = form.save()
273272
project.save()
274-
trigger_build(project, basic=True)
273+
trigger_build(project)
275274
messages.success(
276275
request, _('Your demo project is currently being imported'))
277276
else:

readthedocs/rtd_tests/tests/test_core_utils.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ def test_trigger_build_time_limit(self, update_docs):
3030
kwargs={
3131
'pk': self.project.id,
3232
'force': False,
33-
'basic': False,
3433
'record': True,
3534
'build_pk': mock.ANY,
3635
'version_pk': self.version.id
@@ -51,7 +50,6 @@ def test_trigger_build_invalid_time_limit(self, update_docs):
5150
kwargs={
5251
'pk': self.project.id,
5352
'force': False,
54-
'basic': False,
5553
'record': True,
5654
'build_pk': mock.ANY,
5755
'version_pk': self.version.id
@@ -72,7 +70,6 @@ def test_trigger_build_rounded_time_limit(self, update_docs):
7270
kwargs={
7371
'pk': self.project.id,
7472
'force': False,
75-
'basic': False,
7673
'record': True,
7774
'build_pk': mock.ANY,
7875
'version_pk': self.version.id

0 commit comments

Comments
 (0)