Skip to content

Commit 2bdc987

Browse files
authored
Don't display the build suggestions div if there are no suggestions (#3389)
This added extraneous spacing to the build page.
1 parent 00b081d commit 2bdc987

File tree

1 file changed

+19
-20
lines changed

1 file changed

+19
-20
lines changed

readthedocs/templates/builds/build_detail.html

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -92,28 +92,27 @@
9292
</span>
9393
</div>
9494

95-
<div class="build-ideas">
9695
{% if not build.success and build.commands.count < 4 %}
97-
<p>
98-
99-
{% url 'wipe_version' build.version.project.slug build.version.slug as wipe_url %}
100-
{% blocktrans %}
101-
Having trouble with your build environment?
102-
Try <a href="{{ wipe_url }}">reseting it</a>.
103-
{% endblocktrans %}
104-
</p>
105-
{% endif %}
106-
107-
{% if not build.success and "setup.py install" in build.commands.last.output %}
108-
<p>
109-
{% url 'projects_advanced' build.version.project.slug as advanced_url %}
110-
{% blocktrans %}
111-
Don't want <em>setup.py install</em> called?
112-
Change the <strong>Install Project</strong> setting in your <a href="{{ advanced_url }}">advanced settings</a>.
113-
{% endblocktrans %}
114-
</p>
96+
<div class="build-ideas">
97+
<p>
98+
{% url 'wipe_version' build.version.project.slug build.version.slug as wipe_url %}
99+
{% blocktrans %}
100+
Having trouble with your build environment?
101+
Try <a href="{{ wipe_url }}">reseting it</a>.
102+
{% endblocktrans %}
103+
</p>
104+
</div>
105+
{% elif not build.success and "setup.py install" in build.commands.last.output %}
106+
<div class="build-ideas">
107+
<p>
108+
{% url 'projects_advanced' build.version.project.slug as advanced_url %}
109+
{% blocktrans %}
110+
Don't want <em>setup.py install</em> called?
111+
Change the <strong>Install Project</strong> setting in your <a href="{{ advanced_url }}">advanced settings</a>.
112+
{% endblocktrans %}
113+
</p>
114+
</div>
115115
{% endif %}
116-
</div>
117116

118117
{% if build.output %}
119118
{# If we have build output, this is an old build #}

0 commit comments

Comments
 (0)