Skip to content

Commit 274136f

Browse files
committed
Set privacy level explicitly
This is needed to fix tests in the corporate site where all versions are private by default. Some tests expect them to be public.
1 parent c9e9070 commit 274136f

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

readthedocs/proxito/tests/base.py

+13
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from django.test import TestCase
77
from django.test.utils import override_settings
88

9+
from readthedocs.projects.constants import PUBLIC
910
from readthedocs.projects.models import Project
1011

1112

@@ -26,31 +27,43 @@ def setUp(self):
2627
version_privacy_level='project', users=[self.eric],
2728
main_language_project=None,
2829
)
30+
self.project.versions.update(privacy_level=PUBLIC)
31+
2932
self.subproject = fixture.get(
3033
Project,
3134
slug='subproject',
3235
users=[self.eric],
3336
main_language_project=None,
37+
privacy_level=PUBLIC,
3438
)
39+
self.subproject.versions.update(privacy_level=PUBLIC)
3540
self.project.add_subproject(self.subproject)
3641
self.translation = fixture.get(
3742
Project,
3843
language='es',
3944
slug='translation',
4045
users=[self.eric],
46+
privacy_level=PUBLIC,
4147
main_language_project=self.project,
4248
)
49+
self.translation.versions.update(privacy_level=PUBLIC)
50+
4351
self.subproject_translation = fixture.get(
4452
Project,
4553
language='es',
4654
slug='subproject-translation',
4755
users=[self.eric],
4856
main_language_project=self.subproject,
57+
privacy_level=PUBLIC,
4958
)
59+
self.subproject_translation.versions.update(privacy_level=PUBLIC)
60+
5061
self.subproject_alias = fixture.get(
5162
Project,
5263
language='en',
5364
slug='subproject-alias',
5465
users=[self.eric],
66+
privacy_level=PUBLIC,
5567
)
68+
self.subproject_alias.versions.update(privacy_level=PUBLIC)
5669
self.project.add_subproject(self.subproject_alias, alias='this-is-an-alias')

readthedocs/proxito/tests/test_full.py

+9-2
Original file line numberDiff line numberDiff line change
@@ -280,15 +280,22 @@ def test_sitemap_xml(self):
280280
translation = fixture.get(
281281
Project,
282282
main_language_project=self.project,
283-
language='translation-es'
283+
language='translation-es',
284+
privacy_level=constants.PUBLIC,
284285
)
286+
translation.versions.update(privacy_level=constants.PUBLIC)
285287
# sitemap hreflang should follow correct format.
286288
# ref: https://en.wikipedia.org/wiki/Hreflang#Common_Mistakes
287289
hreflang_test_translation_project = fixture.get(
288290
Project,
289291
main_language_project=self.project,
290-
language='zh_CN'
292+
language='zh_CN',
293+
privacy_level=constants.PUBLIC,
291294
)
295+
hreflang_test_translation_project.versions.update(
296+
privacy_level=constants.PUBLIC,
297+
)
298+
292299
response = self.client.get(
293300
reverse('sitemap_xml'),
294301
HTTP_HOST='project.readthedocs.io',

0 commit comments

Comments
 (0)