Remove unneeded methods to get local paths

Author: humitos

readthedocs/builds/models.py

@@ -396,23 +396,6 @@ def get_build_path(self):
             return path
         return None
 
-    def get_artifact_paths(self):
-        """
-        Return a list of all production artifacts/media path for this version.
-
-        :rtype: list
-        """
-        paths = []
-
-        for type_ in ('pdf', 'epub', 'htmlzip'):
-            paths.append(
-                self.project
-                .get_production_media_path(type_=type_, version_slug=self.slug),
-            )
-        paths.append(self.project.rtd_build_path(version=self.slug))
-
-        return paths
-
     def get_storage_paths(self):
         """
         Return a list of all build artifact storage paths for this version.

readthedocs/projects/models.py

@@ -539,38 +539,6 @@ def get_storage_path(
             )
         return folder_path
 
-    def get_production_media_path(self, type_, version_slug, include_file=True):
-        """
-        Used to see if these files exist so we can offer them for download.
-
-        :param type_: Media content type, ie - 'pdf', 'zip'
-        :param version_slug: Project version slug for lookup
-        :param include_file: Include file name in return
-        :type include_file: bool
-
-        :returns: Full path to media file or path
-        """
-        if settings.DEFAULT_PRIVACY_LEVEL == 'public' or settings.DEBUG:
-            path = os.path.join(
-                settings.MEDIA_ROOT,
-                type_,
-                self.slug,
-                version_slug,
-            )
-        else:
-            path = os.path.join(
-                settings.PRODUCTION_MEDIA_ARTIFACTS,
-                type_,
-                self.slug,
-                version_slug,
-            )
-        if include_file:
-            path = os.path.join(
-                path,
-                '{}.{}'.format(self.slug, type_.replace('htmlzip', 'zip')),
-            )
-        return path
-
     def get_production_media_url(self, type_, version_slug):
         """Get the URL for downloading a specific media file."""
         # Use project domain for full path --same domain as docs
@@ -740,12 +708,6 @@ def has_good_build(self):
         return self.builds(manager=INTERNAL).filter(success=True).exists()
 
     def has_media(self, type_, version_slug=LATEST, version_type=None):
-        path = self.get_production_media_path(
-            type_=type_, version_slug=version_slug
-        )
-        if os.path.exists(path):
-            return True
-
         storage = get_storage_class(settings.RTD_BUILD_MEDIA_STORAGE)()
         storage_path = self.get_storage_path(
             type_=type_, version_slug=version_slug,

readthedocs/rtd_tests/tests/test_celery.py

@@ -82,22 +82,6 @@ def test_remove_dirs(self):
         self.assertTrue(result.successful())
         self.assertFalse(exists(directory))
 
-    def test_clear_artifacts(self):
-        version = self.project.versions.all()[0]
-        directory = self.project.get_production_media_path(type_='pdf', version_slug=version.slug)
-        os.makedirs(directory)
-        self.assertTrue(exists(directory))
-        result = tasks.remove_dirs.delay(paths=version.get_artifact_paths())
-        self.assertTrue(result.successful())
-        self.assertFalse(exists(directory))
-
-        directory = version.project.rtd_build_path(version=version.slug)
-        os.makedirs(directory)
-        self.assertTrue(exists(directory))
-        result = tasks.remove_dirs.delay(paths=version.get_artifact_paths())
-        self.assertTrue(result.successful())
-        self.assertFalse(exists(directory))
-
     @patch('readthedocs.projects.tasks.UpdateDocsTaskStep.setup_python_environment', new=MagicMock)
     @patch('readthedocs.projects.tasks.UpdateDocsTaskStep.build_docs', new=MagicMock)
     @patch('readthedocs.projects.tasks.UpdateDocsTaskStep.setup_vcs', new=MagicMock)
@@ -164,7 +148,7 @@ def test_update_docs_unexpected_build_exception(self, mock_build_docs):
     @patch('readthedocs.projects.tasks.UpdateDocsTaskStep.setup_vcs')
     def test_no_notification_on_version_locked_error(self, mock_setup_vcs, mock_send_notifications):
         mock_setup_vcs.side_effect = VersionLockedError()
-        
+
         version = self.project.versions.first()
 
         build = get(