Tests for PR Build tab on project dashboard added

Author: saadmk11

readthedocs/builds/views.py

@@ -137,13 +137,7 @@ def get_queryset(self):
 
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
-
-        active_builds = self.get_queryset().exclude(
-            state='finished',
-        ).values('id')
-
         context['project'] = self.project
-        context['active_builds'] = active_builds
         context['versions'] = Version.external.public(
             user=self.request.user,
             project=self.project,

readthedocs/rtd_tests/tests/test_builds.py

@@ -7,6 +7,7 @@
 from django_dynamic_fixture import fixture, get
 from django.utils import timezone
 
+from readthedocs.builds.constants import PULL_REQUEST
 from readthedocs.builds.models import Build, Version
 from readthedocs.doc_builder.config import load_yaml_config
 from readthedocs.doc_builder.environments import LocalBuildEnvironment
@@ -582,3 +583,27 @@ def test_using_latest_config(self):
         build.save()
 
         self.assertTrue(build.using_latest_config())
+
+    def test_build_is_pr(self):
+        # Turn the build version to pull request type.
+        self.version.type = PULL_REQUEST
+        self.version.save()
+
+        pr_build = get(
+            Build,
+            project=self.project,
+            version=self.version,
+            config={'version': 1},
+        )
+
+        self.assertTrue(pr_build.is_pr)
+
+    def test_build_is_not_pr(self):
+        build = get(
+            Build,
+            project=self.project,
+            version=self.version,
+            config={'version': 1},
+        )
+
+        self.assertFalse(build.is_pr)

readthedocs/rtd_tests/tests/test_managers.py

@@ -2,11 +2,7 @@
 from django.test import TestCase
 from django_dynamic_fixture import get
 
-<<<<<<< HEAD
 from readthedocs.builds.constants import EXTERNAL, BRANCH, TAG
-=======
-from readthedocs.builds.constants import PULL_REQUEST, BRANCH, TAG
->>>>>>> build manager tests added
 from readthedocs.builds.models import Version, Build
 from readthedocs.projects.constants import PUBLIC, PRIVATE, PROTECTED
 from readthedocs.projects.models import Project

readthedocs/rtd_tests/tests/test_project.py

@@ -166,6 +166,12 @@ def test_has_good_build_excludes_external_versions(self):
         # Test that PR Version is not considered for has_good_build.
         self.assertFalse(self.pip.has_good_build)
 
+    def test_get_pr_builds_url(self):
+        self.assertEqual(
+            self.pip.get_pr_builds_url(),
+            f'/projects/{self.pip.slug}/builds/pr/'
+        )
+
 
 class TestProjectTranslations(ProjectMixin, TestCase):
 

readthedocs/rtd_tests/tests/test_views.py

@@ -294,6 +294,46 @@ def test_build_list_does_not_include_external_versions(self):
             reverse('builds_project_list', args=[self.pip.slug]),
         )
         self.assertEqual(response.status_code, 200)
-
         self.assertNotIn(external_version_build, response.context['build_qs'])
         self.assertNotIn(external_version_build, response.context['active_builds'])
+
+    def test_pr_build_list_includes_pr_version_builds(self):
+        pr_version = get(
+            Version,
+            project = self.pip,
+            active = True,
+            type = PULL_REQUEST,
+        )
+        pr_version_build = get(
+            Build,
+            project = self.pip,
+            version = pr_version
+        )
+        response = self.client.get(
+            reverse('pr_builds_project_list', args=[self.pip.slug]),
+        )
+
+        self.assertEqual(response.status_code, 200)
+        self.assertIn(pr_version_build, response.context['build_qs'])
+
+    def test_pr_build_list_does_not_include_internal_version_builds(self):
+        internal_version = get(
+            Version,
+            project = self.pip,
+            active = True,
+            type = BRANCH,
+        )
+        internal_version_build = get(
+            Build,
+            project = self.pip,
+            version = internal_version
+        )
+        response = self.client.get(
+            reverse('pr_builds_project_list', args=[self.pip.slug]),
+        )
+
+        self.assertEqual(response.status_code, 200)
+        self.assertNotIn(
+            internal_version_build,
+            response.context['build_qs']
+        )