Skip to content

Commit 235514a

Browse files
committed
Update tests
1 parent fdcb280 commit 235514a

File tree

1 file changed

+17
-12
lines changed

1 file changed

+17
-12
lines changed

readthedocs/projects/tests/test_build_tasks.py

+17-12
Original file line numberDiff line numberDiff line change
@@ -535,8 +535,11 @@ def test_successful_build(
535535
"builder": mock.ANY,
536536
}
537537

538+
# NOTE: `request_history[5]` is a temporal notification that will be removed after October 7th
539+
# https://github.com/readthedocs/readthedocs.org/pull/11514
540+
538541
# Update build state: installing
539-
assert self.requests_mock.request_history[5].json() == {
542+
assert self.requests_mock.request_history[6].json() == {
540543
"id": 1,
541544
"state": "installing",
542545
"commit": "a1b2c3",
@@ -599,7 +602,7 @@ def test_successful_build(
599602
},
600603
}
601604
# Update build state: building
602-
assert self.requests_mock.request_history[6].json() == {
605+
assert self.requests_mock.request_history[7].json() == {
603606
"id": 1,
604607
"state": "building",
605608
"commit": "a1b2c3",
@@ -609,7 +612,7 @@ def test_successful_build(
609612
"error": "",
610613
}
611614
# Update build state: uploading
612-
assert self.requests_mock.request_history[7].json() == {
615+
assert self.requests_mock.request_history[8].json() == {
613616
"id": 1,
614617
"state": "uploading",
615618
"commit": "a1b2c3",
@@ -619,9 +622,9 @@ def test_successful_build(
619622
"error": "",
620623
}
621624
# Update version state
622-
assert self.requests_mock.request_history[8]._request.method == "PATCH"
623-
assert self.requests_mock.request_history[8].path == "/api/v2/version/1/"
624-
assert self.requests_mock.request_history[8].json() == {
625+
assert self.requests_mock.request_history[9]._request.method == "PATCH"
626+
assert self.requests_mock.request_history[9].path == "/api/v2/version/1/"
627+
assert self.requests_mock.request_history[9].json() == {
625628
"addons": False,
626629
"build_data": None,
627630
"built": True,
@@ -631,11 +634,13 @@ def test_successful_build(
631634
"has_htmlzip": True,
632635
}
633636
# Set project has valid clone
634-
assert self.requests_mock.request_history[9]._request.method == "PATCH"
635-
assert self.requests_mock.request_history[9].path == "/api/v2/project/1/"
636-
assert self.requests_mock.request_history[9].json() == {"has_valid_clone": True}
637-
# Update build state: finished, success and builder
637+
assert self.requests_mock.request_history[10]._request.method == "PATCH"
638+
assert self.requests_mock.request_history[10].path == "/api/v2/project/1/"
638639
assert self.requests_mock.request_history[10].json() == {
640+
"has_valid_clone": True
641+
}
642+
# Update build state: finished, success and builder
643+
assert self.requests_mock.request_history[11].json() == {
639644
"id": 1,
640645
"state": "finished",
641646
"commit": "a1b2c3",
@@ -647,8 +652,8 @@ def test_successful_build(
647652
"error": "",
648653
}
649654

650-
assert self.requests_mock.request_history[11]._request.method == "POST"
651-
assert self.requests_mock.request_history[11].path == "/api/v2/revoke/"
655+
assert self.requests_mock.request_history[12]._request.method == "POST"
656+
assert self.requests_mock.request_history[12].path == "/api/v2/revoke/"
652657

653658
assert BuildData.objects.all().exists()
654659

0 commit comments

Comments
 (0)