Rename redirect_type to type in the APIv3 response

Author: humitos

readthedocs/api/v3/serializers.py

@@ -11,7 +11,7 @@
 from readthedocs.builds.models import Build, Version
 from readthedocs.projects.constants import LANGUAGES, PROGRAMMING_LANGUAGES
 from readthedocs.projects.models import Project
-from readthedocs.redirects.models import Redirect
+from readthedocs.redirects.models import Redirect, TYPE_CHOICES as REDIRECT_TYPE_CHOICES
 
 
 class UserSerializer(FlexFieldsModelSerializer):
@@ -495,14 +495,16 @@ class RedirectSerializerBase(serializers.ModelSerializer):
     modified = serializers.DateTimeField(source='update_dt', read_only=True)
     _links = RedirectLinksSerializer(source='*', read_only=True)
 
+    type = serializers.ChoiceField(source='redirect_type', choices=REDIRECT_TYPE_CHOICES)
+
     class Meta:
         model = Redirect
         fields = [
             'pk',
             'created',
             'modified',
             'project',
-            'redirect_type',
+            'type',
             'from_url',
             'to_url',
             '_links',

readthedocs/api/v3/tests/responses/projects-redirects-detail.json

@@ -8,6 +8,6 @@
     "from_url": "/docs/",
     "pk": 1,
     "project": "project",
-    "redirect_type": "page",
+    "type": "page",
     "to_url": "/documentation/"
 }

readthedocs/api/v3/tests/responses/projects-redirects-detail_PUT.json

@@ -8,6 +8,6 @@
     "from_url": "/changed/",
     "pk": 1,
     "project": "project",
-    "redirect_type": "page",
+    "type": "page",
     "to_url": "/toanother/"
 }

readthedocs/api/v3/tests/responses/projects-redirects-list.json

@@ -13,7 +13,7 @@
             "from_url": "/docs/",
             "pk": 1,
             "project": "project",
-            "redirect_type": "page",
+            "type": "page",
             "to_url": "/documentation/"
         }
     ]

readthedocs/api/v3/tests/responses/projects-redirects-list_POST.json

@@ -8,6 +8,6 @@
     "from_url": "/page/",
     "pk": 2,
     "project": "project",
-    "redirect_type": "page",
+    "type": "page",
     "to_url": "/another/"
 }

readthedocs/api/v3/tests/test_projects.py

@@ -468,7 +468,7 @@ def test_projects_redirects_list_post(self):
         data = {
             'from_url': '/page/',
             'to_url': '/another/',
-            'redirect_type': 'page',
+            'type': 'page',
         }
 
         self.client.credentials(HTTP_AUTHORIZATION=f'Token {self.token.key}')
@@ -494,7 +494,7 @@ def test_projects_redirects_detail_put(self):
         data = {
             'from_url': '/changed/',
             'to_url': '/toanother/',
-            'redirect_type': 'page',
+            'type': 'page',
         }
 
         self.client.credentials(HTTP_AUTHORIZATION=f'Token {self.token.key}')