Add some tests for Redirect endpoints

Author: humitos

readthedocs/api/v3/serializers.py

@@ -491,12 +491,16 @@ def get_project(self, obj):
 class RedirectSerializerBase(serializers.ModelSerializer):
 
     project = serializers.SlugRelatedField(slug_field='slug', read_only=True)
+    created = serializers.DateTimeField(source='create_dt', read_only=True)
+    modified = serializers.DateTimeField(source='update_dt', read_only=True)
     _links = RedirectLinksSerializer(source='*', read_only=True)
 
     class Meta:
         model = Redirect
         fields = [
             'pk',
+            'created',
+            'modified',
             'project',
             'redirect_type',
             'from_url',

readthedocs/api/v3/tests/responses/projects-redirects-detail.json

@@ -0,0 +1,13 @@
+{
+    "_links": {
+        "_self": "https://readthedocs.org/api/v3/projects/project/redirects/1/",
+        "project": "https://readthedocs.org/api/v3/projects/project/"
+    },
+    "created": "2019-04-29T10:00:00Z",
+    "modified": "2019-04-29T12:00:00Z",
+    "from_url": "/docs/",
+    "pk": 1,
+    "project": "project",
+    "redirect_type": "page",
+    "to_url": "/documentation/"
+}

readthedocs/api/v3/tests/responses/projects-redirects-list.json

@@ -0,0 +1,20 @@
+{
+    "count": 1,
+    "next": null,
+    "previous": null,
+    "results": [
+        {
+            "_links": {
+                "_self": "https://readthedocs.org/api/v3/projects/project/redirects/1/",
+                "project": "https://readthedocs.org/api/v3/projects/project/"
+            },
+            "created": "2019-04-29T10:00:00Z",
+            "modified": "2019-04-29T12:00:00Z",
+            "from_url": "/docs/",
+            "pk": 1,
+            "project": "project",
+            "redirect_type": "page",
+            "to_url": "/documentation/"
+        }
+    ]
+}

readthedocs/api/v3/tests/responses/projects-redirects-list_POST.json

@@ -0,0 +1,13 @@
+{
+    "_links": {
+        "_self": "https://readthedocs.org/api/v3/projects/project/redirects/2/",
+        "project": "https://readthedocs.org/api/v3/projects/project/"
+    },
+    "created": "2019-04-29T10:00:00Z",
+    "modified": "2019-04-29T12:00:00Z",
+    "from_url": "/page/",
+    "pk": 2,
+    "project": "project",
+    "redirect_type": "page",
+    "to_url": "/another/"
+}

readthedocs/api/v3/tests/test_projects.py

@@ -13,6 +13,7 @@
 
 from readthedocs.builds.models import Build, Version
 from readthedocs.projects.models import Project
+from readthedocs.redirects.models import Redirect
 
 
 class APIEndpointTests(TestCase):
@@ -49,6 +50,16 @@ def setUp(self):
         for tag in ('tag', 'project', 'test'):
             self.project.tags.add(tag)
 
+        self.redirect = fixture.get(
+            Redirect,
+            create_dt=created,
+            update_dt=modified,
+            from_url='/docs/',
+            to_url='/documentation/',
+            redirect_type='page',
+            project=self.project,
+        )
+
         self.subproject = fixture.get(
             Project,
             pub_date=created,
@@ -372,3 +383,109 @@ def test_projects_versions_detail_unique(self):
 
         )
         self.assertEqual(response.status_code, 200)
+
+    def test_unauthed_projects_redirects_list(self):
+        response = self.client.get(
+            reverse(
+                'projects-redirects-list',
+                kwargs={
+                    'parent_lookup_project__slug': self.project.slug,
+                }),
+        )
+        self.assertEqual(response.status_code, 401)
+
+    def test_projects_redirects_list(self):
+        self.client.credentials(HTTP_AUTHORIZATION=f'Token {self.token.key}')
+        response = self.client.get(
+            reverse(
+                'projects-redirects-list',
+                kwargs={
+                    'parent_lookup_project__slug': self.project.slug,
+                }),
+        )
+        self.assertEqual(response.status_code, 200)
+
+        response_json = response.json()
+        self.assertDictEqual(
+            response_json,
+            self._get_response_dict('projects-redirects-list'),
+        )
+
+    def test_unauthed_projects_redirects_detail(self):
+        response = self.client.get(
+            reverse(
+                'projects-redirects-detail',
+                kwargs={
+                    'parent_lookup_project__slug': self.project.slug,
+                    'redirect_pk': self.redirect.pk,
+                }),
+        )
+        self.assertEqual(response.status_code, 401)
+
+    def test_projects_redirects_detail(self):
+        self.client.credentials(HTTP_AUTHORIZATION=f'Token {self.token.key}')
+        response = self.client.get(
+            reverse(
+                'projects-redirects-detail',
+                kwargs={
+                    'parent_lookup_project__slug': self.project.slug,
+                    'redirect_pk': self.redirect.pk,
+                }),
+        )
+        self.assertEqual(response.status_code, 200)
+
+        response_json = response.json()
+        self.assertDictEqual(
+            response_json,
+            self._get_response_dict('projects-redirects-detail'),
+        )
+
+    def test_unauthed_projects_redirects_list_post(self):
+        data = {}
+
+        response = self.client.post(
+            reverse(
+                'projects-redirects-list',
+                kwargs={
+                    'parent_lookup_project__slug': self.others_project.slug,
+                }),
+            data,
+        )
+        self.assertEqual(response.status_code, 401)
+
+        self.client.credentials(HTTP_AUTHORIZATION=f'Token {self.token.key}')
+        response = self.client.post(
+            reverse(
+                'projects-redirects-list',
+                kwargs={
+                    'parent_lookup_project__slug': self.others_project.slug,
+                }),
+            data,
+        )
+        self.assertEqual(response.status_code, 403)
+
+    def test_projects_redirects_list_post(self):
+        data = {
+            'from_url': '/page/',
+            'to_url': '/another/',
+            'redirect_type': 'page',
+        }
+
+        self.client.credentials(HTTP_AUTHORIZATION=f'Token {self.token.key}')
+        response = self.client.post(
+            reverse(
+                'projects-redirects-list',
+                kwargs={
+                    'parent_lookup_project__slug': self.project.slug,
+                }),
+            data,
+        )
+        self.assertEqual(response.status_code, 201)
+
+        response_json = response.json()
+        response_json['created'] = '2019-04-29T10:00:00Z'
+        response_json['modified'] = '2019-04-29T12:00:00Z'
+        self.assertDictEqual(
+            response_json,
+            self._get_response_dict('projects-redirects-list_POST'),
+        )