Re-introduce delete=False flag for search reindex in reindex_elasticsearch command

Author: gregmuellegger

readthedocs/core/management/commands/reindex_elasticsearch.py

@@ -47,6 +47,7 @@ def handle(self, *args, **options):
                 commit = None
 
             try:
-                update_search(version.pk, commit)
+                update_search(version.pk, commit,
+                              delete_non_commit_files=False)
             except Exception:
                 log.error('Reindex failed for %s' % version, exc_info=True)

readthedocs/projects/tasks.py

@@ -613,11 +613,12 @@ def move_files(version_pk, hostname, html=False, localmedia=False, search=False,
 
 
 @task(queue='web')
-def update_search(version_pk, commit):
+def update_search(version_pk, commit, delete_non_commit_files=True):
     """Task to update search indexes
 
     :param version_pk: Version id to update
     :param commit: Commit that updated index
+    :param delete_non_commit_files: Delete files not in commit from index
     """
     version = Version.objects.get(pk=version_pk)
 
@@ -642,6 +643,7 @@ def update_search(version_pk, commit):
         # Don't index sections to speed up indexing.
         # They aren't currently exposed anywhere.
         section=False,
+        delete=delete_non_commit_files,
     )