mkdocs isn't required when documentation_type is sphinx

bsipocz · bsipocz · commit 1a6bcf693e72 · 2017-06-30T12:29:22.000+01:00
diff --git a/readthedocs/doc_builder/python_environments.py b/readthedocs/doc_builder/python_environments.py
@@ -236,6 +236,9 @@ def install_core_requirements(self):
             'recommonmark',
         ]
 
+        if self.project.documentation_type == 'mkdocs':
+            pip_requirements.append('mkdocs')
+
         pip_cmd = [
             'python',
             self.venv_bin(filename='pip'),

Original file line number	Diff line number	Diff line change
`@@ -236,6 +236,9 @@ def install_core_requirements(self):`
`236`	`236`	`'recommonmark',`
`237`	`237`	`]`
`238`	`238`
	`239`	`+ if self.project.documentation_type == 'mkdocs':`
	`240`	`+ pip_requirements.append('mkdocs')`
	`241`	`+`
`239`	`242`	`pip_cmd = [`
`240`	`243`	`'python',`
`241`	`244`	`self.venv_bin(filename='pip'),`