Minor updates

Author: humitos

readthedocs/doc_builder/director.py

@@ -188,7 +188,7 @@ def build(self):
         self.build_epub()
 
         self.run_build_job("post_build")
-        self.generate_readthedocs_data_javascript()
+        self.store_readthedocs_build_yaml()
 
         after_build.send(
             sender=self.data.version,
@@ -394,7 +394,7 @@ def run_build_commands(self):
         # Update the `Version.documentation_type` to match the doctype defined
         # by the config file. When using `build.commands` it will be `GENERIC`
         self.data.version.documentation_type = self.data.config.doctype
-        self.generate_readthedocs_data_javascript()
+        self.store_readthedocs_build_yaml()
 
     def install_build_tools(self):
         """
@@ -629,7 +629,7 @@ def is_type_sphinx(self):
         """Is documentation type Sphinx."""
         return "sphinx" in self.data.config.doctype
 
-    def generate_readthedocs_data_javascript(self):
+    def store_readthedocs_build_yaml(self):
         # load YAML from user
         yaml_path = os.path.join(
             self.data.project.artifact_path(
@@ -639,18 +639,20 @@ def generate_readthedocs_data_javascript(self):
         )
 
         try:
-            log.warning(yaml_path)
-            data = yaml.safe_load(open(yaml_path, "r"))
+            with open(yaml_path, "r") as f:
+                data = yaml.safe_load(f)
         except Exception:
-            # NOTE: skip this work for now until we decide whether or not this YAML file is required.
-            # NOTE: decide whether or not we want this file to be mandatory and raise an exception here.
-            log.info("No `readthedocs-build.yaml` was provided.")
+            # NOTE: skip this work for now until we decide whether or not this
+            # YAML file is required.
+            #
+            # NOTE: decide whether or not we want this
+            # file to be mandatory and raise an exception here.
             return
 
         log.info("readthedocs-build.yaml loaded.", path=yaml_path)
 
         # TODO: validate the YAML generated by the user
-        # self._validate_readthedocs_data_yaml(data)
+        # self._validate_readthedocs_build_yaml(data)
 
         # Copy the YAML data into `Version.build_data`.
         # It will be saved when the API is hit.