Skip to content

Commit 17ab950

Browse files
committed
Pass environmemt to signals
1 parent d81a0f4 commit 17ab950

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

readthedocs/projects/signals.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
import django.dispatch
44

55

6-
before_vcs = django.dispatch.Signal(providing_args=['version'])
6+
before_vcs = django.dispatch.Signal(providing_args=['version', 'environmemt'])
77
after_vcs = django.dispatch.Signal(providing_args=['version'])
88

9-
before_build = django.dispatch.Signal(providing_args=['version'])
9+
before_build = django.dispatch.Signal(providing_args=['version', 'environmemt'])
1010
after_build = django.dispatch.Signal(providing_args=['version'])
1111

1212
project_import = django.dispatch.Signal(providing_args=['project'])

readthedocs/projects/tasks.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def run(self, version_pk): # pylint: disable=arguments-differ
248248
update_on_success=False,
249249
)
250250

251-
before_vcs.send(sender=self.version)
251+
before_vcs.send(sender=self.version, environment=environment)
252252
with self.project.repo_nonblockinglock(version=self.version):
253253
self.sync_repo(environment)
254254
return True
@@ -464,7 +464,7 @@ def run_setup(self, record=True):
464464
# Environment used for code checkout & initial configuration reading
465465
with environment:
466466
try:
467-
before_vcs.send(sender=self.version)
467+
before_vcs.send(sender=self.version, environment=environment)
468468
if self.project.skip:
469469
raise ProjectBuildsSkippedError
470470
try:
@@ -569,6 +569,10 @@ def run_build(self, docker, record):
569569
)
570570

571571
try:
572+
before_build.send(
573+
sender=self.version,
574+
environment=self.build_env,
575+
)
572576
with self.project.repo_nonblockinglock(version=self.version):
573577
self.setup_python_environment()
574578

@@ -1004,7 +1008,6 @@ def build_docs(self):
10041008
:rtype: dict
10051009
"""
10061010
self.build_env.update_build(state=BUILD_STATE_BUILDING)
1007-
before_build.send(sender=self.version)
10081011

10091012
outcomes = defaultdict(lambda: False)
10101013
outcomes['html'] = self.build_docs_html()

0 commit comments

Comments
 (0)