Skip to content

Commit 176542f

Browse files
committed
Remove old/deprecated build endpoints
1 parent 4291265 commit 176542f

File tree

3 files changed

+11
-326
lines changed

3 files changed

+11
-326
lines changed

readthedocs/core/urls/__init__.py

+1-15
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1-
# -*- coding: utf-8 -*-
2-
31
"""URL configuration for core app."""
42

53
from __future__ import absolute_import
64
from django.conf.urls import url
75

86
from readthedocs.constants import pattern_opts
97
from readthedocs.core import views
10-
from readthedocs.core.views import hooks, serve
8+
from readthedocs.core.views import serve
119
from readthedocs.projects.feeds import LatestProjectsFeed, NewProjectsFeed
1210

1311
docs_urls = [
@@ -43,18 +41,6 @@
4341
]
4442

4543
core_urls = [
46-
# Hooks
47-
url(r'^github', hooks.github_build, name='github_build'),
48-
url(r'^gitlab', hooks.gitlab_build, name='gitlab_build'),
49-
url(r'^bitbucket', hooks.bitbucket_build, name='bitbucket_build'),
50-
url(
51-
(
52-
r'^build/'
53-
r'(?P<project_id_or_slug>{project_slug})'.format(**pattern_opts)
54-
),
55-
hooks.generic_build,
56-
name='generic_build',
57-
),
5844
# Random other stuff
5945
url(
6046
r'^random/(?P<project_slug>{project_slug})'.format(**pattern_opts),

readthedocs/core/views/__init__.py

+10-12
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
31
"""
42
Core views, including the main homepage,
53
@@ -15,25 +13,18 @@
1513
from django.shortcuts import render, get_object_or_404, redirect
1614
from django.views.generic import TemplateView
1715

18-
1916
from readthedocs.builds.models import Version
2017
from readthedocs.core.utils.general import wipe_version_via_slugs
2118
from readthedocs.core.resolver import resolve_path
2219
from readthedocs.core.symlink import PrivateSymlink, PublicSymlink
23-
from readthedocs.core.utils import broadcast
2420
from readthedocs.core.views.serve import _serve_file
2521
from readthedocs.projects.constants import PRIVATE
2622
from readthedocs.projects.models import Project, ImportedFile
27-
from readthedocs.projects.tasks import remove_dirs
2823
from readthedocs.redirects.utils import get_redirect_response, project_and_path_from_request, language_and_version_from_path
2924

3025
log = logging.getLogger(__name__)
3126

3227

33-
class NoProjectException(Exception):
34-
pass
35-
36-
3728
class HomepageView(TemplateView):
3829

3930
template_name = 'homepage.html'
@@ -90,7 +81,7 @@ def wipe_version(request, project_slug, version_slug):
9081
if request.method == 'POST':
9182
wipe_version_via_slugs(
9283
version_slug=version_slug,
93-
project_slug=project_slug
84+
project_slug=project_slug,
9485
)
9586
return redirect('project_version_list', project_slug)
9687
return render(
@@ -188,7 +179,10 @@ def resolve_404_path(project, version_slug=None, language=None):
188179
fullpath = os.path.join(basepath, filename)
189180
return (basepath, filename, fullpath)
190181

191-
project, full_path = project_and_path_from_request(request, request.get_full_path())
182+
project, full_path = project_and_path_from_request(
183+
request,
184+
request.get_full_path(),
185+
)
192186

193187
if project:
194188
language = None
@@ -200,7 +194,11 @@ def resolve_404_path(project, version_slug=None, language=None):
200194
# Firstly, attempt to serve the 404 of the current version (version_slug)
201195
# Secondly, try to serve the 404 page for the default version (project.get_default_version())
202196
for slug in (version_slug, project.get_default_version()):
203-
basepath, filename, fullpath = resolve_404_path(project, slug, language)
197+
basepath, filename, fullpath = resolve_404_path(
198+
project,
199+
slug,
200+
language,
201+
)
204202
if os.path.exists(fullpath):
205203
log.debug(
206204
'serving 404.html page current version: [project: %s] [version: %s]',

0 commit comments

Comments
 (0)