Skip to content

Commit 0962c94

Browse files
committed
Make some part of the codebase single source
1 parent 29df29e commit 0962c94

File tree

7 files changed

+49
-19
lines changed

7 files changed

+49
-19
lines changed

readthedocs/projects/migrations/0007_migrate_canonical_data.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# -*- coding: utf-8 -*-
2-
from __future__ import unicode_literals
2+
from __future__ import unicode_literals, print_function
33

44
from django.db import migrations
55
from django.db import transaction
@@ -15,12 +15,12 @@ def migrate_canonical(apps, schema_editor):
1515
url=project.canonical_url,
1616
canonical=True,
1717
)
18-
print u"Added {url} to {project}".format(url=project.canonical_url, project=project.name)
19-
except Exception, e:
20-
print e
21-
print u"Failed adding {url} to {project}".format(
18+
print(u"Added {url} to {project}".format(url=project.canonical_url, project=project.name))
19+
except Exception as e:
20+
print(e)
21+
print(u"Failed adding {url} to {project}".format(
2222
url=project.canonical_url, project=project.name
23-
)
23+
))
2424

2525

2626
class Migration(migrations.Migration):

readthedocs/projects/migrations/0010_migrate_domain_data.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,24 @@
11
# -*- coding: utf-8 -*-
2-
from __future__ import unicode_literals
2+
from __future__ import unicode_literals, print_function
33

44
from django.db import models, migrations
55
import readthedocs.core.validators
66

7-
from urlparse import urlparse
7+
import sys
8+
9+
if sys.version_info > (3,):
10+
import urllib.parse as urlparse
11+
else:
12+
import urlparse
813

914

1015
def migrate_url(apps, schema_editor):
1116
Domain = apps.get_model("projects", "Domain")
1217
Domain.objects.filter(count=0).delete()
1318
for domain in Domain.objects.all():
1419
if domain.project.superprojects.count() or domain.project.main_language_project:
15-
print "{project} is a subproject or translation. Deleting domain.".format(
16-
project=domain.project.slug)
20+
print("{project} is a subproject or translation. Deleting domain.".format(
21+
project=domain.project.slug))
1722
domain.delete()
1823
continue
1924
parsed = urlparse(domain.url)
@@ -24,10 +29,10 @@ def migrate_url(apps, schema_editor):
2429
try:
2530
domain.domain = domain_string
2631
domain.save()
27-
print u"Added {domain} from {url}".format(url=domain.url, domain=domain_string)
28-
except Exception, e:
29-
print e
30-
print u"Failed {domain} from {url}".format(url=domain.url, domain=domain_string)
32+
print(u"Added {domain} from {url}".format(url=domain.url, domain=domain_string))
33+
except Exception as e:
34+
print(e)
35+
print(u"Failed {domain} from {url}".format(url=domain.url, domain=domain_string))
3136

3237
dms = Domain.objects.filter(domain=domain_string).order_by('-count')
3338
if dms.count() > 1:

readthedocs/projects/models.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,13 @@
33
import fnmatch
44
import logging
55
import os
6-
from urlparse import urlparse
6+
7+
import sys
8+
9+
if sys.version_info > (3,):
10+
from urllib.parse import urlparse
11+
else:
12+
from urlparse import urlparse
713

814
from django.conf import settings
915
from django.contrib.auth.models import User

readthedocs/redirects/admin.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
from __future__ import absolute_import
2+
13
from django.contrib import admin
2-
from models import Redirect
4+
from .models import Redirect
35

46

57
class RedirectAdmin(admin.ModelAdmin):

readthedocs/vcs_support/backends/bzr.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
import csv
22
import re
3-
from StringIO import StringIO
3+
4+
import sys
5+
6+
if sys.version_info > (3,):
7+
from io import StringIO
8+
else:
9+
from StringIO import StringIO
410

511
from readthedocs.projects.exceptions import ProjectImportError
612
from readthedocs.vcs_support.base import BaseVCS, VCSVersion

readthedocs/vcs_support/backends/git.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@
22
import logging
33
import csv
44
import os
5-
from StringIO import StringIO
5+
6+
import sys
7+
if sys.version_info > (3,):
8+
from io import StringIO
9+
else:
10+
from StringIO import StringIO
611

712
from readthedocs.projects.exceptions import ProjectImportError
813
from readthedocs.vcs_support.base import BaseVCS, VCSVersion

readthedocs/vcs_support/backends/svn.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
import csv
2-
from StringIO import StringIO
2+
3+
import sys
4+
if sys.version_info > (3,):
5+
from io import StringIO
6+
else:
7+
from StringIO import StringIO
8+
39

410
from readthedocs.projects.exceptions import ProjectImportError
511
from readthedocs.vcs_support.base import BaseVCS, VCSVersion

0 commit comments

Comments
 (0)