webhook notification url size validation check

Author: chirathr

readthedocs/projects/forms.py

@@ -476,7 +476,7 @@ class WebHookForm(forms.Form):
 
     """Project webhook form."""
 
-    url = forms.URLField()
+    url = forms.URLField(max_length=WebHook._meta.get_field('url').max_length)
 
     def __init__(self, *args, **kwargs):
         self.project = kwargs.pop('project', None)

readthedocs/projects/models.py

@@ -965,7 +965,7 @@ def __str__(self):
 
 @python_2_unicode_compatible
 class WebHook(Notification):
-    url = models.URLField(blank=True,
+    url = models.URLField(max_length=600, blank=True,
                           help_text=_('URL to send the webhook to'))
 
     def __str__(self):

readthedocs/projects/views/private.py

@@ -510,15 +510,20 @@ def project_notifications(request, project_slug):
     webhook_form = WebHookForm(data=request.POST or None, project=project)
 
     if request.method == 'POST':
-        if email_form.is_valid():
-            email_form.save()
-        if webhook_form.is_valid():
-            webhook_form.save()
+        if 'email' not in request.POST:
+            email_form = EmailHookForm(data=None, project=project)
+        if 'url' not in request.POST:
+            webhook_form = WebHookForm(data=None, project=project)
         project_dashboard = reverse(
             'projects_notifications',
             args=[project.slug],
         )
-        return HttpResponseRedirect(project_dashboard)
+        if email_form.is_valid():
+            email_form.save()
+            return HttpResponseRedirect(project_dashboard)
+        if webhook_form.is_valid():
+            webhook_form.save()
+            return HttpResponseRedirect(project_dashboard)
 
     emails = project.emailhook_notifications.all()
     urls = project.webhook_notifications.all()