Move auto detection for doctype

Author: stsewd

readthedocs/projects/models.py

@@ -318,6 +318,11 @@ def save(self, *args, **kwargs):  # pylint: disable=arguments-differ
             self.slug = slugify(self.name)
             if self.slug == '':
                 raise Exception(_('Model must have slug'))
+        if self.documentation_type == 'auto':
+            # This used to determine the type and automatically set the
+            # documentation type to Sphinx for rST and Mkdocs for markdown.
+            # It now just forces Sphinx, due to markdown support.
+            self.documentation_type = 'sphinx'
         super(Project, self).save(*args, **kwargs)
         for owner in self.users.all():
             assign('view_project', owner, self)

readthedocs/projects/tasks.py

@@ -470,10 +470,6 @@ def run_build(self, docker, record):
 
         # Environment used for building code, usually with Docker
         with self.build_env:
-
-            if self.project.documentation_type == 'auto':
-                self.update_documentation_type()
-
             python_env_cls = Virtualenv
             if self.config.conda is not None:
                 self._log('Using conda')
@@ -589,21 +585,6 @@ def set_valid_clone(self):
         self.project.has_valid_clone = True
         self.version.project.has_valid_clone = True
 
-    def update_documentation_type(self):
-        """
-        Force Sphinx for 'auto' documentation type.
-
-        This used to determine the type and automatically set the documentation
-        type to Sphinx for rST and Mkdocs for markdown. It now just forces
-        Sphinx, due to markdown support.
-        """
-        ret = 'sphinx'
-        project_data = api_v2.project(self.project.pk).get()
-        project_data['documentation_type'] = ret
-        api_v2.project(self.project.pk).put(project_data)
-        self.project.documentation_type = ret
-        self.version.project.documentation_type = ret
-
     def update_app_instances(self, html=False, localmedia=False, search=False,
                              pdf=False, epub=False):
         """