Skip to content

Commit 0039c23

Browse files
committed
Log user agent on invalid click/view
1 parent d7a60ef commit 0039c23

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

readthedocs/donate/views.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,12 @@ def click_proxy(request, promo_id, hash):
124124
project = Project.objects.get(slug=project_slug)
125125
promo.incr(CLICKS, project=project)
126126
else:
127-
log.warning('Duplicate click logged. {count} total clicks tried.'.format(count=count))
127+
agent = request.META.get('HTTP_USER_AGENT', 'Unknown')
128+
log.warning(
129+
'Duplicate click logged. {count} total clicks tried. User Agent: [{agent}]'.format(
130+
count=count, agent=agent
131+
)
132+
)
128133
cache.incr(promo.cache_key(type=CLICKS, hash=hash))
129134
raise Http404('Invalid click. This has been logged.')
130135
return redirect(promo.link)
@@ -148,7 +153,12 @@ def view_proxy(request, promo_id, hash):
148153
project = Project.objects.get(slug=project_slug)
149154
promo.incr(VIEWS, project=project)
150155
else:
151-
log.warning('Duplicate view logged. {count} total clicks tried.'.format(count=count))
156+
agent = request.META.get('HTTP_USER_AGENT', 'Unknown')
157+
log.warning(
158+
'Duplicate view logged. {count} total views tried. User Agent: [{agent}]'.format(
159+
count=count, agent=agent
160+
)
161+
)
152162
cache.incr(promo.cache_key(type=VIEWS, hash=hash))
153163
raise Http404('Invalid click. This has been logged.')
154164
return redirect(promo.image)

0 commit comments

Comments
 (0)