Skip to content

Commit 4d356fa

Browse files
authored
Add support for Ubuntu 24.04 LTS (#207)
Required by readthedocs/readthedocs.org#11072
1 parent a11cdea commit 4d356fa

File tree

6 files changed

+16
-12
lines changed

6 files changed

+16
-12
lines changed

.circleci/config.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
# DOCKER_IMAGES full names come from the Docker Hub
2121
name: Download Docker images
2222
command: |
23-
DOCKER_IMAGES="ubuntu-22.04-2024.01.29 ubuntu-20.04-2024.01.29"
23+
DOCKER_IMAGES="ubuntu-24.04-2024.06.17 ubuntu-22.04-2024.01.29 ubuntu-20.04-2024.01.29"
2424
for docker_image in $DOCKER_IMAGES
2525
do
2626
docker pull readthedocs/build:$docker_image
@@ -35,7 +35,7 @@ jobs:
3535
command: |
3636
declare -A TOOLS
3737
38-
OS_NAMES="ubuntu-22.04 ubuntu-20.04"
38+
OS_NAMES="ubuntu-24.04 ubuntu-22.04 ubuntu-20.04"
3939
TOOLS=(
4040
["python"]="2.7.18 3.6.15 3.7.17 3.8.19 3.9.19 3.10.14 3.11.9 3.12.3 miniconda3-4.7.12 miniconda3-3.12-24.1.2-0 mambaforge-4.10.3-10 mambaforge-22.9.0-3 mambaforge-23.11.0-0"
4141
["nodejs"]="14.20.1 16.18.1 18.16.1 19.0.1 20.14.0"
@@ -94,7 +94,7 @@ jobs:
9494
pipenv install
9595
- run:
9696
name: Build Docker image
97-
command: docker build -t readthedocs/build:ubuntu-22.04 .
97+
command: docker build -t readthedocs/build:ubuntu-24.04 .
9898
- run:
9999
name: Run tests
100100
command: pipenv run pytest

CONTRIBUTING.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ If you'd like to add a feature to any of the images, you'll need to verify the
1818
image works locally first. After making changes to the ``Dockerfile``, you can
1919
build your image with::
2020

21-
docker build -t readthedocs/build:ubuntu-20.04 .
21+
docker build -t readthedocs/build:ubuntu-24.04 .
2222

2323
This will take quite a long time, mostly due to LaTeX dependencies. The
2424
resulting image will be around 5GB.
2525

2626
Once your image is built, you can test your image locally by running a shell in
2727
a container using your new image::
2828

29-
docker run --rm -t -i readthedocs/build:ubuntu-20.04 /bin/bash
29+
docker run --rm -t -i readthedocs/build:ubuntu-24.04 /bin/bash
3030

3131
This will put you into the root path in the container, as the ``docs`` user.
3232
From here you can head to your home path (``cd ~docs``) and run normal

Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Read the Docs - Environment base
2-
FROM ubuntu:22.04
2+
FROM ubuntu:24.04
33
LABEL mantainer="Read the Docs <[email protected]>"
4-
LABEL version="ubuntu-22.04-2024.01.29"
4+
LABEL version="ubuntu-24.04-2024.06.17"
55

66
ENV DEBIAN_FRONTEND noninteractive
77
ENV LANG C.UTF-8

README.rst

+6-2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ repository:
1616
Ubuntu 22.04 supporting multiple versions of Python, PyPy, conda, mamba, nodejs, rust and go.
1717
Available for public usage as ``build.os: ubuntu-22.04``
1818

19+
`readthedocs/build:ubuntu-24.04-YYYY.MM.DD`
20+
Ubuntu 24.04 supporting multiple versions of Python, PyPy, conda, mamba, nodejs, rust and go.
21+
Available for public usage as ``build.os: ubuntu-24.04``
22+
1923
Note that these images only contains the basic dependencies:
2024

2125
- ``asdf`` CLI manager to install the languages versions
@@ -35,7 +39,7 @@ Usage
3539

3640
To use the pre-built images, you can pull from Docker Hub:
3741

38-
docker pull readthedocs/build:ubuntu-22.04-YYYY.MM.DD
42+
docker pull readthedocs/build:ubuntu-24.04-YYYY.MM.DD
3943

4044
.. note::
4145

@@ -44,7 +48,7 @@ To use the pre-built images, you can pull from Docker Hub:
4448

4549
You can also compile these images locally:
4650

47-
docker build -t readthedocs/build:ubuntu-22.04-YYYY.MM.DD .
51+
docker build -t readthedocs/build:ubuntu-24.04-YYYY.MM.DD .
4852

4953
See `CONTRIBUTING`_ for more information on building and testing.
5054

tests/constants.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
DOCKER_IMAGE = 'readthedocs/build:ubuntu-22.04'
1+
DOCKER_IMAGE = 'readthedocs/build:ubuntu-24.04'

tests/test_versions.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
[
1010
('asdf version', 'v0.14.0-ccdd47d'),
1111
('asdf plugin list', '\n'.join(['golang', 'nodejs', 'python', 'ruby', 'rust'])),
12-
('git --version', 'git version 2.34.1'),
12+
('git --version', 'git version 2.43.0'),
1313
]
1414
)
15-
def test_command_versions_image_ubuntu22(command, expected_output):
15+
def test_command_versions_image_ubuntu24(command, expected_output):
1616
cmd_output = run_command_in_container(DOCKER_IMAGE, command)
1717
assert cmd_output == expected_output

0 commit comments

Comments
 (0)