You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 18, 2022. It is now read-only.
I don't fully understand this, at the end the top level configuration file is the one that is considered to load the settings and the nested file is ignored?
There were some wonky ideas around the spec for our config early on. I do believe that child readthedocs.yml files will merge into the parent file. I'd probably say we don't want this behavior at all, right? If i have a parent readthedocs.yml file, there should be no case where I want my child readthedocs.yml file parsed. The only case I can think of is a repo with multiple projects in it, and potentially multiple readthedocs.yml files.
+1 to removing this, and only supporting one file. I believe the "rtd.yml selection" code already does this, so we should remove the complexity in parsing that is needed for this support.
But here the filter isn't needed, since the code only loads and parse one configuration file (about this should be the test, then? Test that the code only parse one configuration file on load?).
Looking quickly, it doesn't appear we have tests to test how a configuration file is merged if a nested configuration file is found.
I would expect:
readthedocs.yml
configuration has precedencereadthedocs.yml
doesn't merge in its keys to our configurationThe text was updated successfully, but these errors were encountered: