Skip to content

TestEnvironment constructor mixes up timeout, no signal timeout and poll timeout #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Azquelt opened this issue Jun 26, 2020 · 2 comments

Comments

@Azquelt
Copy link

Azquelt commented Jun 26, 2020

If either the TestEnvironment() or TestEnvironment(long defaultTimeoutMillis, long defaultNoSignalsTimeoutMillis) constructor is used:

  • defaultNoSignalsTimeoutMillis is set to the value intended for defaultTimeoutMillis
  • defaultPollTimeoutMillis is set to the value intended for defaultNoSignalsTimeoutMillis

This is due to the way that arguments are passed here: https://github.com/reactive-streams/reactive-streams-jvm/blob/master/tck/src/main/java/org/reactivestreams/tck/TestEnvironment.java#L106-L108

  public TestEnvironment(long defaultTimeoutMillis, long defaultNoSignalsTimeoutMillis) {
    this(defaultTimeoutMillis, defaultTimeoutMillis, defaultNoSignalsTimeoutMillis);
  }

I'm not sure what the correct value for the third argument is, but the second argument should definitely be defaultNoSignalsTimeoutMillis rather than defaultTimeoutMillis.

@viktorklang
Copy link
Contributor

@Azquelt Fixed in master!

@Azquelt
Copy link
Author

Azquelt commented Sep 16, 2020

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants