-
Notifications
You must be signed in to change notification settings - Fork 534
Publisher behavior after cancellation of Subscription? #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I just found the set of rules in the master, especially rule 6 and 8 apply. So maybe I can refine the question: Do calls of Subscription::cancel represent a request for cancellation that has to be acknowledged by the Publisher, or does the Publisher have to regard a Subscription canceled as soon as Subscription::cancel is called? If there has to be an acknowledgment, the question would be via onError or onComplete? My intuition would be onError, since the Publisher did not complete regularly. |
Hi Max, To answer your question directly - there is no need for the Publisher to "confirm that he got the cancellation", the Subscriber can start shutting down as soon as he's issued the cancelation. OnError and OnComplete are reserved for when the publisher terminates the Subscription. |
Hi Konrad, Thanks again, |
Glad I could help! Somewhat related: In case you're working on an implementation, you may be interested in the soon-to-be-merged TCK: #91 |
That will indeed be helpful. Thanks for pointing it out. I am working on a Publisher implementation only. I will run it against the relevant parts of the TCK, as soon as it is in the master. |
Great, looking forward to it! :-) |
Hello,
There seems to be no definition if a Publisher should notify a subscriber with onComplete or onError if the subscriber canceled the Subscribtion. Or should the Publisher silently accept the cancellation?
Did I overlook something or is there no defined behavior indeed?
Thanks,
Max
The text was updated successfully, but these errors were encountered: