adapt TCK to changes in rule 3.17

Specifically remove
required_spec317_mustSignalOnErrorWhenPendingAboveLongMaxValue since it
is now allowed to treat request overflow as “unlimited demand”.

Author: rkuhn

tck/src/main/java/org/reactivestreams/tck/IdentityProcessorVerification.java

@@ -356,11 +356,6 @@ public void required_spec317_mustSupportACumulativePendingElementCountUpToLongMa
     publisherVerification.required_spec317_mustSupportACumulativePendingElementCountUpToLongMaxValue();
   }
 
-  @Override @Test
-  public void required_spec317_mustSignalOnErrorWhenPendingAboveLongMaxValue() throws Throwable {
-    publisherVerification.required_spec317_mustSignalOnErrorWhenPendingAboveLongMaxValue();
-  }
-
   // Verifies rule: https://github.com/reactive-streams/reactive-streams#1.4
   // for multiple subscribers
   @Test 
@@ -727,4 +722,4 @@ public void expectError(Throwable cause, long timeoutMillis) throws InterruptedE
       }
     }
   }
-}
+}

tck/src/main/java/org/reactivestreams/tck/PublisherVerification.java

@@ -939,43 +939,6 @@ public void run(Publisher<T> pub) throws Throwable {
     });
   }
 
-  // Verifies rule: https://github.com/reactive-streams/reactive-streams#3.17
-  @Override @Test
-  public void required_spec317_mustSignalOnErrorWhenPendingAboveLongMaxValue() throws Throwable {
-    activePublisherTest(Integer.MAX_VALUE, false, new PublisherTestRun<T>() {
-      @Override public void run(Publisher<T> pub) throws Throwable {
-        ManualSubscriberWithSubscriptionSupport<T> sub = new BlackholeSubscriberWithSubscriptionSupport<T>(env) {
-           // arbitrarily set limit on nuber of request calls signalled, we expect overflow after already 2 calls,
-           // so 10 is relatively high and safe even if arbitrarily chosen
-          int callsCounter = 10;
-
-          @Override
-          public void onNext(T element) {
-            env.debug(String.format("%s::onNext(%s)", this, element));
-            if (subscription.isCompleted()) {
-              if (callsCounter > 0) {
-                subscription.value().request(Long.MAX_VALUE - 1);
-                callsCounter--;
-              }
-            } else {
-              env.flop(String.format("Subscriber::onNext(%s) called before Subscriber::onSubscribe", element));
-            }
-          }
-        };
-        env.subscribe(pub, sub, env.defaultTimeoutMillis());
-
-        // eventually triggers `onNext`, which will then trigger up to `callsCounter` times `request(Long.MAX_VALUE - 1)`
-        // we're pretty sure to overflow from those
-        sub.request(1);
-
-        sub.expectErrorWithMessage(IllegalStateException.class, "3.17");
-
-        // onError must be signalled only once, even with in-flight other request() messages that would trigger overflow again
-        env.verifyNoAsyncErrors(env.defaultTimeoutMillis());
-      }
-    });
-  }
-
   ///////////////////// ADDITIONAL "COROLLARY" TESTS ////////////////////////
 
   ///////////////////// TEST INFRASTRUCTURE /////////////////////////////////
@@ -1091,4 +1054,4 @@ public void notVerified(String message) {
     throw new SkipException(message);
   }
 
-}
+}

tck/src/main/java/org/reactivestreams/tck/support/PublisherVerificationRules.java

@@ -39,5 +39,4 @@ public interface PublisherVerificationRules {
   void required_spec313_cancelMustMakeThePublisherEventuallyDropAllReferencesToTheSubscriber() throws Throwable;
   void required_spec317_mustSupportAPendingElementCountUpToLongMaxValue() throws Throwable;
   void required_spec317_mustSupportACumulativePendingElementCountUpToLongMaxValue() throws Throwable;
-  void required_spec317_mustSignalOnErrorWhenPendingAboveLongMaxValue() throws Throwable;
-}
+}

tck/src/test/java/org/reactivestreams/tck/PublisherVerificationTest.java

@@ -443,40 +443,6 @@ public void required_spec317_mustSupportAPendingElementCountUpToLongMaxValue_sho
     }, "Received more than bufferSize (32) onNext signals. The Publisher probably emited more signals than expected!");
   }
 
-  @Test
-  public void required_spec317_mustSignalOnErrorWhenPendingAboveLongMaxValue_shouldFail_onAsynchDemandIgnoringPublisher() throws Throwable {
-    final ExecutorService signallersPool = Executors.newFixedThreadPool(2);
-    requireTestFailure(new ThrowingRunnable() {
-      @Override public void run() throws Throwable {
-        demandIgnoringAsynchronousPublisherVerification(signallersPool).required_spec317_mustSignalOnErrorWhenPendingAboveLongMaxValue();
-      }
-    }, "Expected onError(java.lang.IllegalStateException)");
-  }
-
-  @Test
-  public void required_spec317_mustSignalOnErrorWhenPendingAboveLongMaxValue_shouldFail_onSynchDemandIgnoringPublisher() throws Throwable {
-    requireTestFailure(new ThrowingRunnable() {
-      @Override public void run() throws Throwable {
-        customPublisherVerification(new Publisher<Integer>() {
-          long demand = 0;
-
-          @Override public void subscribe(final Subscriber<? super Integer> s) {
-            s.onSubscribe(new Subscription() {
-              @Override public void request(long n) {
-                // it does not protect from demand overflow!
-                demand += n;
-              }
-
-              @Override public void cancel() {
-                // noop
-              }
-            });
-          }
-        }).required_spec317_mustSignalOnErrorWhenPendingAboveLongMaxValue();
-      }
-    }, "Expected onError(java.lang.IllegalStateException)");
-  }
-
   @Test
   public void required_spec317_mustSupportACumulativePendingElementCountUpToLongMaxValue_shouldFail_overflowingDemand() throws Throwable {
     requireTestFailure(new ThrowingRunnable() {