Fixed #188 by making 2.12 an unverified rule, as it cannot be deterministically verified.

Author: viktorklang

tck/src/main/java/org/reactivestreams/tck/IdentityProcessorVerification.java

@@ -541,8 +541,8 @@ public void unverified___spec211_mustMakeSureThatAllCallsOnItsMethodsHappenBefor
   }
 
   @Override @Test
-  public void optional___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_specViolation() throws Throwable {
-    subscriberVerification.optional___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_specViolation();
+  public void unverified___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_specViolation() throws Throwable {
+    subscriberVerification.unverified___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_specViolation();
   }
 
   @Override @Test

tck/src/main/java/org/reactivestreams/tck/SubscriberBlackboxVerification.java

@@ -281,7 +281,7 @@ public void unverified___spec211_blackbox_mustMakeSureThatAllCallsOnItsMethodsHa
 
   // Verifies rule: https://github.com/reactive-streams/reactive-streams#2.12
   @Override @Test
-  public void required___spec212_blackbox_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality() throws Throwable {
+  public void unverified___spec212_blackbox_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality() throws Throwable {
     notVerified(); // cannot be meaningfully tested as black box, or can it?
   }
 

tck/src/main/java/org/reactivestreams/tck/SubscriberWhiteboxVerification.java

@@ -342,30 +342,8 @@ public void unverified___spec211_mustMakeSureThatAllCallsOnItsMethodsHappenBefor
 
   // Verifies rule: https://github.com/reactive-streams/reactive-streams#2.12
   @Override @Test
-  public void optional___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_specViolation() throws Throwable {
-    optionalSubscriberTestWithoutSetup(new TestStageTestRun() {
-      @Override @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
-      public void run(WhiteboxTestStage stage) throws Exception {
-        stage.pub = stage.createHelperPublisher(1);
-
-        stage.tees = new ManualSubscriberWithSubscriptionSupport<T>(env);
-
-        env.subscribe(stage.pub, stage.tees);
-        stage.tees.expectNone();
-
-        // subscribe the same subscriber again,
-        // this can not use convinience subscribe(pub, sub), because that one checks for noAsyncErrors
-        // instead we expect the error afterwards
-        stage.pub.subscribe(stage.tees); // NOTE: This is a spec violation!
-
-        // NOTE: It would be nice to signal an error in response to such spec violation, however
-        // reacting to spec violations is not strictly regulated by the Spec - for example, just logging and ignoring may
-        // also be a valid response to this spec violation - it's up to the implementation
-        //
-        // The TCK is able to check only for onErroring in such case, thus the check below and the optional nature of this test
-        stage.tees.expectError(Exception.class, "Should not allow subscribing the same instance multiple times, see Reactive Streams Specification Rule 2.12");
-      }
-    });
+  public void unverified___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_specViolation() throws Throwable {
+    notVerified(); // cannot be meaningfully tested, or can it?
   }
 
   // Verifies rule: https://github.com/reactive-streams/reactive-streams#2.13

tck/src/main/java/org/reactivestreams/tck/support/SubscriberBlackboxVerificationRules.java

@@ -18,7 +18,7 @@ public interface SubscriberBlackboxVerificationRules {
   void required___spec209_blackbox_mustBePreparedToReceiveAnOnCompleteSignalWithoutPrecedingRequestCall() throws Throwable;
   void required___spec210_blackbox_mustBePreparedToReceiveAnOnErrorSignalWithPrecedingRequestCall() throws Throwable;
   void unverified___spec211_blackbox_mustMakeSureThatAllCallsOnItsMethodsHappenBeforeTheProcessingOfTheRespectiveEvents() throws Exception;
-  void required___spec212_blackbox_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality() throws Throwable;
+  void unverified___spec212_blackbox_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality() throws Throwable;
   void unverified___spec213_blackbox_failingOnSignalInvocation() throws Exception;
   void unverified___spec301_blackbox_mustNotBeCalledOutsideSubscriberContext() throws Exception;
   void required___spec308_blackbox_requestMustRegisterGivenNumberElementsToBeProduced() throws Throwable;

tck/src/main/java/org/reactivestreams/tck/support/SubscriberWhiteboxVerificationRules.java

@@ -20,7 +20,7 @@ public interface SubscriberWhiteboxVerificationRules {
   void required___spec210_mustBePreparedToReceiveAnOnErrorSignalWithPrecedingRequestCall() throws Throwable;
   void required___spec210_mustBePreparedToReceiveAnOnErrorSignalWithoutPrecedingRequestCall() throws Throwable;
   void unverified___spec211_mustMakeSureThatAllCallsOnItsMethodsHappenBeforeTheProcessingOfTheRespectiveEvents() throws Exception;
-  void optional___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_specViolation() throws Throwable;
+  void unverified___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_specViolation() throws Throwable;
   void unverified___spec213_failingOnSignalInvocation() throws Exception;
   void unverified___spec301_mustNotBeCalledOutsideSubscriberContext() throws Exception;
   void required___spec308_requestMustRegisterGivenNumberElementsToBeProduced() throws Throwable;

tck/src/test/java/org/reactivestreams/tck/SubscriberWhiteboxVerificationTest.java

@@ -283,23 +283,7 @@ public Subscriber<Integer> apply(WhiteboxSubscriberProbe<Integer> probe) throws
       }
     }, "Test Exception: Boom!"); // checks that the expected exception was delivered to onError, we don't expect anyone to implement onError so weirdly
   }
-
-  @Test
-  public void optional___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_shouldFail_ifItAcceptsTheSameSubscriberMoreTimes() throws Throwable {
-    requireTestFailure(new ThrowingRunnable() {
-      @Override public void run() throws Throwable {
-
-        customSubscriberVerification(new Function<WhiteboxSubscriberProbe<Integer>, Subscriber<Integer>>() {
-          @Override
-          public Subscriber<Integer> apply(WhiteboxSubscriberProbe<Integer> probe) throws Throwable {
-            return new SimpleSubscriberWithProbe(probe) {
-            };
-          }
-        }).optional___spec212_mustNotCallOnSubscribeMoreThanOnceBasedOnObjectEquality_specViolation();
-      }
-    }, "");
-  }
-
+  
   @Test
   public void required___spec308_requestMustRegisterGivenNumberElementsToBeProduced_shouldFail() throws Throwable {
     // sanity checks the "happy path", that triggerRequest() propagates the right demand