=tck move back to inspecting subscription.isCompleted thanks to new impl

Author: ktoso

Diff for: tck/src/main/java/org/reactivestreams/tck/TestEnvironment.java

@@ -572,8 +572,6 @@ public void expectNone(long withinMillis, String errMsgPrefix) throws Interrupte
 
   public static class ManualSubscriberWithSubscriptionSupport<T> extends ManualSubscriber<T> {
 
-    private final AtomicBoolean onSubscribeCalled = new AtomicBoolean();
-
     public ManualSubscriberWithSubscriptionSupport(TestEnvironment env) {
       super(env);
     }
@@ -591,7 +589,7 @@ public void onNext(T element) {
     @Override
     public void onComplete() {
       env.debug(this + "::onComplete()");
-      if (onSubscribeCalled.get()) {
+      if (subscription.isCompleted()) {
         super.onComplete();
       } else {
         env.flop("Subscriber::onComplete() called before Subscriber::onSubscribe");
@@ -603,7 +601,6 @@ public void onSubscribe(Subscription s) {
       env.debug(String.format("%s::onSubscribe(%s)", this, s));
       if (!subscription.isCompleted()) {
         subscription.complete(s);
-        onSubscribeCalled.set(true);
       } else {
         env.flop("Subscriber::onSubscribe called on an already-subscribed Subscriber");
       }
@@ -612,7 +609,7 @@ public void onSubscribe(Subscription s) {
     @Override
     public void onError(Throwable cause) {
       env.debug(String.format("%s::onError(%s)", this, cause));
-      if (onSubscribeCalled.get()) {
+      if (subscription.isCompleted()) {
         super.onError(cause);
       } else {
         env.flop(cause, String.format("Subscriber::onError(%s) called before Subscriber::onSubscribe", cause));
@@ -806,7 +803,7 @@ public void expectCancelling() throws InterruptedException {
     public void expectCancelling(long timeoutMillis) throws InterruptedException {
       cancelled.expectClose(timeoutMillis, "Did not receive expected cancelling of upstream subscription");
     }
-    
+
     public boolean isCancelled() throws InterruptedException {
       return cancelled.isClosed();
     }