Skip to content

Commit 0138433

Browse files
committed
=tck remove unnecessary createHelperPublisher overrides
1 parent f6367fe commit 0138433

File tree

3 files changed

+2
-28
lines changed

3 files changed

+2
-28
lines changed

examples/src/test/java/org/reactivestreams/example/unicast/AsyncSubscriberTest.java

-3
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,4 @@ public AsyncSubscriberTest() {
6060
return element;
6161
}
6262

63-
@Override public Publisher<Integer> createHelperPublisher(long elements) {
64-
return super.createHelperPublisher(elements);
65-
}
6663
}

tck/src/main/java/org/reactivestreams/tck/IdentityProcessorVerification.java

-22
Original file line numberDiff line numberDiff line change
@@ -124,28 +124,6 @@ public boolean skipStochasticTests() {
124124
*/
125125
public abstract Processor<T, T> createIdentityProcessor(int bufferSize);
126126

127-
/**
128-
* Helper method required for creating the Publisher to which the tested Subscriber will be subscribed and tested against.
129-
* <p>
130-
* By default an <b>asynchronously signalling Publisher</b> is provided, which will use
131-
* {@link org.reactivestreams.tck.SubscriberBlackboxVerification#createElement(int)} to generate elements type
132-
* your Subscriber is able to consume.
133-
* <p>
134-
* Sometimes you may want to implement your own custom custom helper Publisher - to validate behaviour of a Subscriber
135-
* when facing a synchronous Publisher for example. If you do, it MUST emit the exact number of elements asked for
136-
* (via the {@code elements} parameter) and MUST also must treat the following numbers of elements in these specific ways:
137-
* <ul>
138-
* <li>
139-
* If {@code elements} is {@code Long.MAX_VALUE} the produced stream must be infinite.
140-
* </li>
141-
* <li>
142-
* If {@code elements} is {@code 0} the {@code Publisher} should signal {@code onComplete} immediatly.
143-
* In other words, it should represent a "completed stream".
144-
* </li>
145-
* </ul>
146-
*/
147-
public abstract Publisher<T> createHelperPublisher(long elements);
148-
149127
/**
150128
* Return a Publisher that immediately signals {@code onError} to incoming subscriptions,
151129
* or {@code null} in order to skip them.

tck/src/main/java/org/reactivestreams/tck/WithHelperPublisher.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,8 @@ public abstract class WithHelperPublisher<T> {
3838
/**
3939
* Helper method required for creating the Publisher to which the tested Subscriber will be subscribed and tested against.
4040
* <p>
41-
* By default an <b>asynchronously signalling Publisher</b> is provided, which will use
42-
* {@link org.reactivestreams.tck.SubscriberBlackboxVerification#createElement(int)} to generate elements type
43-
* your Subscriber is able to consume.
41+
* By default an <b>asynchronously signalling Publisher</b> is provided, which will use {@link #createElement(int)}
42+
* to generate elements type your Subscriber is able to consume.
4443
* <p>
4544
* Sometimes you may want to implement your own custom custom helper Publisher - to validate behaviour of a Subscriber
4645
* when facing a synchronous Publisher for example. If you do, it MUST emit the exact number of elements asked for

0 commit comments

Comments
 (0)