Skip to content

Don't strip Script tag elements #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Archmonger opened this issue Aug 8, 2022 · 2 comments · Fixed by #1239
Closed

Don't strip Script tag elements #797

Archmonger opened this issue Aug 8, 2022 · 2 comments · Fixed by #1239
Labels
flag-good-first-issue A well defined and self-contained task. priority-3-low May be resolved one any timeline.

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Aug 8, 2022

Current Situation

The client code currently strips script tags and replaces them with div.

For example, this script element wont appear within the browser's DOM.

@component
def my_component():
   return html.script("console.log('hello_world');")

Proposed Actions

Remove this behavior, since we now officially support script within ReactPy. There's no longer any reason to visually hide the script tag.

@Archmonger Archmonger added flag-good-first-issue A well defined and self-contained task. priority-3-low May be resolved one any timeline. labels Aug 8, 2022
@Archmonger Archmonger modified the milestones: 1.0, 2.0 Aug 8, 2022
@rmorshea rmorshea removed this from the Luxury milestone Feb 21, 2023
@rishabhRsinghvi
Copy link

@Archmonger
Please assign this stuff to me, I think I can do this.

@Archmonger
Copy link
Contributor Author

@rishabhRsinghvi We do not use the GitHub issue assignment feature. Feel free to open a PR and link it to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag-good-first-issue A well defined and self-contained task. priority-3-low May be resolved one any timeline.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants