Skip to content

Improve idom.run warning #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Archmonger opened this issue Apr 8, 2022 · 0 comments · Fixed by #842
Closed

Improve idom.run warning #724

Archmonger opened this issue Apr 8, 2022 · 0 comments · Fixed by #842
Labels
flag-good-first-issue A well defined and self-contained task. type-revision About a change in functionality or behavior
Milestone
1.0.0

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Apr 8, 2022 •
edited
Loading

Current Situation

Currently, the idom.run warning does not provide anything actionable. When users see You are running a development server. Change this before deploying in production! they will not understand what to change in order to resolve this warning.

Proposed Actions

I recommend changing the warning to this: idom.run() is only intended for testing purposes. For production use, consider embedding IDOM within an existing project. Check out the docs for more info.
@Archmonger Archmonger added the type-revision About a change in functionality or behavior label Apr 8, 2022
@Archmonger Archmonger added this to the 1.0 milestone Apr 8, 2022
@Archmonger Archmonger added the flag-good-first-issue A well defined and self-contained task. label Jun 27, 2022
@rmorshea rmorshea mentioned this issue Nov 29, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag-good-first-issue A well defined and self-contained task. type-revision About a change in functionality or behavior
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

better run func warning reactive-python/reactpy
1 participant
@Archmonger