Skip to content

Change Layout Context Manager to be Async #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmorshea opened this issue Feb 18, 2022 · 0 comments · Fixed by #730
Closed

Change Layout Context Manager to be Async #677

rmorshea opened this issue Feb 18, 2022 · 0 comments · Fixed by #730
Labels
priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior
Milestone

Comments

@rmorshea
Copy link
Collaborator

Current Situation

Currently the context manager for the layout is not async even though its render and deliver methods are async. I'm not quite sure why I thought this was a good idea. Technically the context methods don't need to be async, but the mismatch is odd. Additionally, if the context methods were async, we could ensure that all effects are completed before exiting the context.

Proposed Actions

Switch the context management methods to be async and wait for effects to complete before exiting.

@rmorshea rmorshea added priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior labels Feb 18, 2022
@rmorshea rmorshea added this to the 2.0 milestone Feb 18, 2022
@rmorshea rmorshea modified the milestones: 2.0, 1.0 Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant