Skip to content

MyPy plugin to warn for component unpacking operators #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
rmorshea opened this issue Jan 27, 2022 · 5 comments
Closed
1 task

MyPy plugin to warn for component unpacking operators #616

rmorshea opened this issue Jan 27, 2022 · 5 comments
Labels
priority-2-moderate Should be resolved on a reasonable timeline. type-ci About change and updates to the Continuous Integration

Comments

@rmorshea
Copy link
Collaborator

Current Situation

Currently we don't document that using the unpacking operator (*args) has undesirable consequences on whether we do or don't warn about missing keys.

Proposed Actions

Document this fact. If it turns out that, despite this documentation, people run into this issue often, consider changing the syntax.

Work Items

  • add docs on unpacking operator to "Rendering Data" docs.
@rmorshea rmorshea added type-docs About changes and updates to documentation priority-2-moderate Should be resolved on a reasonable timeline. labels Jan 27, 2022
@rmorshea rmorshea added this to the 1.0 milestone Jan 27, 2022
@Archmonger
Copy link
Contributor

@rmorshea Can I add a Todo (Docs) column to the GitHub Project's page to prevent documentation tasks from cluttering the task list?

It's hard to tell at first glance how much development actually needs to go into v1 since there's so many docs changes needed.

@rmorshea
Copy link
Collaborator Author

Go for it. Let me know if you're not able to.

@rmorshea
Copy link
Collaborator Author

rmorshea commented Nov 5, 2022

I think a MyPy plugin could help with this

@Archmonger Archmonger changed the title Document Avoidance of Unpacking Operator MyPy plugin to warn for component unpacking operators Nov 30, 2022
@Archmonger
Copy link
Contributor

Changing this to issue a plugin, and moving to V2.

@Archmonger Archmonger added type-ci About change and updates to the Continuous Integration and removed type-docs About changes and updates to documentation labels Nov 30, 2022
@Archmonger Archmonger modified the milestones: 1.0, 2.0 Nov 30, 2022
@rmorshea rmorshea linked a pull request Dec 1, 2022 that will close this issue
3 tasks
@rmorshea rmorshea mentioned this issue Dec 1, 2022
3 tasks
@Archmonger Archmonger modified the milestones: Luxury, Essential Jan 29, 2023
@rmorshea rmorshea removed this from the Essential milestone Feb 21, 2023
@Archmonger
Copy link
Contributor

Closing this as I intend to lean us away from mypy in near future.

All other reactive-python repos have already been migrated to pyright for type checking, which is substantially faster and generates far less annoying/useless errors.

@Archmonger Archmonger closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2-moderate Should be resolved on a reasonable timeline. type-ci About change and updates to the Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants