Skip to content

Commit a7c4d6c

Browse files
Bugfix for wss protocol issue. (#716)
* fix typo * add console log * change websocket connection * fix error defaulting to ws protocol * undo some changes and typecast secure to boolean * add a console log * add new console log, remove old one * add colon to http * remove console.log * remove Boolean typecast * remove console.log statement * revert build-pkg to older version * add to changelog * changelog entry rewrite Co-authored-by: Ryan Morshead <[email protected]>
1 parent 3664706 commit a7c4d6c

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

docs/source/about/changelog.rst

+8
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,14 @@ Changed:
2323
- :pull:`701`
2424

2525

26+
0.37.2
27+
------
28+
29+
Fixed:
30+
31+
- A typo caused IDOM to use the insecure `ws` web-socket protocol on pages loaded with `https` instead of the secure `wss` protocol - :pull:`716`
32+
33+
2634
0.37.1
2735
------
2836

src/client/packages/idom-app-react/src/index.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@ export function mount(mountPoint) {
66
port: document.location.port,
77
path: "../",
88
query: queryParams.user.toString(),
9-
secture: document.location.protocol == "https",
9+
secure: document.location.protocol == "https:",
1010
});
11-
1211
mountWithLayoutServer(mountPoint, serverInfo, shouldReconnect() ? 45 : 0);
1312
}
1413

0 commit comments

Comments
 (0)