increase default testing timeout

Author: rmorshea

noxfile.py

@@ -390,5 +390,8 @@ def get_idom_script_env() -> dict[str, str]:
     return {
         "PYTHONPATH": os.getcwd(),
         "IDOM_DEBUG_MODE": os.environ.get("IDOM_DEBUG_MODE", "1"),
+        "IDOM_TESTING_DEFAULT_TIMEOUT": os.environ.get(
+            "IDOM_TESTING_DEFAULT_TIMEOUT", "6.0"
+        ),
         "IDOM_CHECK_VDOM_SPEC": os.environ.get("IDOM_CHECK_VDOM_SPEC", "0"),
     }

src/idom/config.py

@@ -77,3 +77,10 @@
 For more information on changes to this feature flag see:
 https://github.com/idom-team/idom/issues/351
 """
+
+IDOM_TESTING_DEFAULT_TIMEOUT = _Option(
+    "IDOM_TESTING_DEFAULT_TIMEOUT",
+    3.0,
+    mutable=False,
+    validator=float,
+)

src/idom/testing/common.py

@@ -10,7 +10,7 @@
 
 from typing_extensions import ParamSpec, Protocol
 
-from idom.config import IDOM_WEB_MODULES_DIR
+from idom.config import IDOM_TESTING_DEFAULT_TIMEOUT, IDOM_WEB_MODULES_DIR
 from idom.core.events import EventHandler, to_event_handler_function
 from idom.core.hooks import LifeCycleHook, current_hook
 
@@ -24,13 +24,10 @@ def clear_idom_web_modules_dir() -> None:
 _P = ParamSpec("_P")
 _R = TypeVar("_R")
 _RC = TypeVar("_RC", covariant=True)
-_DEFAULT_TIMEOUT = 3.0
 
 
 class _UntilFunc(Protocol[_RC]):
-    def __call__(
-        self, condition: Callable[[_RC], bool], timeout: float = _DEFAULT_TIMEOUT
-    ) -> Any:
+    def __call__(self, condition: Callable[[_RC], bool], timeout: float = ...) -> Any:
         ...
 
 
@@ -50,7 +47,8 @@ def __init__(
             coro_function = cast(Callable[_P, Awaitable[_R]], function)
 
             async def coro_until(
-                condition: Callable[[_R], bool], timeout: float = _DEFAULT_TIMEOUT
+                condition: Callable[[_R], bool],
+                timeout: float = IDOM_TESTING_DEFAULT_TIMEOUT.current,
             ) -> None:
                 started_at = time.time()
                 while True:
@@ -68,7 +66,8 @@ async def coro_until(
             sync_function = cast(Callable[_P, _R], function)
 
             def sync_until(
-                condition: Callable[[_R], bool] | Any, timeout: float = _DEFAULT_TIMEOUT
+                condition: Callable[[_R], bool] | Any,
+                timeout: float = IDOM_TESTING_DEFAULT_TIMEOUT.current,
             ) -> None:
                 started_at = time.time()
                 while True:
@@ -83,11 +82,19 @@ def sync_until(
 
             self.until = sync_until
 
-    def until_is(self, right: Any, timeout: float = _DEFAULT_TIMEOUT) -> Any:
+    def until_is(
+        self,
+        right: Any,
+        timeout: float = IDOM_TESTING_DEFAULT_TIMEOUT.current,
+    ) -> Any:
         """Wait until the result is identical to the given value"""
         return self.until(lambda left: left is right, timeout)
 
-    def until_equals(self, right: Any, timeout: float = _DEFAULT_TIMEOUT) -> Any:
+    def until_equals(
+        self,
+        right: Any,
+        timeout: float = IDOM_TESTING_DEFAULT_TIMEOUT.current,
+    ) -> Any:
         """Wait until the result is equal to the given value"""
         # not really sure why I need a type ignore comment here
         return self.until(lambda left: left == right, timeout)  # type: ignore

tests/conftest.py

@@ -7,6 +7,7 @@
 from _pytest.config.argparsing import Parser
 from playwright.async_api import async_playwright
 
+from idom.config import IDOM_TESTING_DEFAULT_TIMEOUT
 from idom.testing import (
     DisplayFixture,
     ServerFixture,
@@ -40,7 +41,7 @@ async def server():
 @pytest.fixture(scope="session")
 async def page(browser):
     pg = await browser.new_page()
-    pg.set_default_timeout(5000)
+    pg.set_default_timeout(IDOM_TESTING_DEFAULT_TIMEOUT.current * 1000)
     try:
         yield pg
     finally: