get suite to run (with failures)

Author: rmorshea

tests/test_client.py

@@ -4,7 +4,6 @@
 
 import idom
 from idom.testing import ServerFixture
-from tests.tooling.browser import send_keys
 
 
 JS_DIR = Path(__file__).parent / "js"

tests/test_core/test_dispatcher.py

@@ -6,13 +6,7 @@
 
 import idom
 from idom.core.layout import Layout, LayoutEvent, LayoutUpdate
-from idom.core.serve import (
-    VdomJsonPatch,
-    _create_shared_view_dispatcher,
-    create_shared_view_dispatcher,
-    ensure_shared_view_dispatcher_future,
-    serve_json_patch,
-)
+from idom.core.serve import VdomJsonPatch, serve_json_patch
 from idom.testing import StaticEventHandler
 
 
@@ -102,87 +96,6 @@ async def test_dispatch():
     assert_changes_produce_expected_model(changes, expected_model)
 
 
-async def test_create_shared_state_dispatcher():
-    events, model = make_events_and_expected_model()
-    changes_1, send_1, recv_1 = make_send_recv_callbacks(events)
-    changes_2, send_2, recv_2 = make_send_recv_callbacks(events)
-
-    async with create_shared_view_dispatcher(Layout(Counter())) as dispatcher:
-        dispatcher(send_1, recv_1)
-        dispatcher(send_2, recv_2)
-
-    assert_changes_produce_expected_model(changes_1, model)
-    assert_changes_produce_expected_model(changes_2, model)
-
-
-async def test_ensure_shared_view_dispatcher_future():
-    events, model = make_events_and_expected_model()
-    changes_1, send_1, recv_1 = make_send_recv_callbacks(events)
-    changes_2, send_2, recv_2 = make_send_recv_callbacks(events)
-
-    dispatch_future, dispatch = ensure_shared_view_dispatcher_future(Layout(Counter()))
-
-    await asyncio.gather(
-        dispatch(send_1, recv_1),
-        dispatch(send_2, recv_2),
-        return_exceptions=True,
-    )
-
-    # the dispatch future should run forever, until cancelled
-    with pytest.raises(asyncio.TimeoutError):
-        await asyncio.wait_for(dispatch_future, timeout=1)
-
-    dispatch_future.cancel()
-    await asyncio.gather(dispatch_future, return_exceptions=True)
-
-    assert_changes_produce_expected_model(changes_1, model)
-    assert_changes_produce_expected_model(changes_2, model)
-
-
-async def test_private_create_shared_view_dispatcher_cleans_up_patch_queues():
-    """Report an issue if this test breaks
-
-    Some internals of idom.core.dispatcher may need to be changed in order to make some
-    internal state easier to introspect.
-
-    Ideally we would just check if patch queues are getting cleaned up more directly,
-    but without having access to that, we use some side effects to try and infer whether
-    it happens.
-    """
-
-    @idom.component
-    def SomeComponent():
-        return idom.html.div()
-
-    async def send(patch):
-        raise idom.Stop()
-
-    async def recv():
-        return LayoutEvent("something", [])
-
-    with idom.Layout(SomeComponent()) as layout:
-        dispatch_shared_view, push_patch = await _create_shared_view_dispatcher(layout)
-
-        # Dispatch a view that should exit. After exiting its patch queue should be
-        # cleaned up and removed. Since we only dispatched one view there should be
-        # no patch queues.
-        await dispatch_shared_view(send, recv)  # this should stop immediately
-
-        # We create a patch and check its ref count. We will check this after attempting
-        # to push out the change.
-        patch = VdomJsonPatch("anything", [])
-        patch_ref_count = sys.getrefcount(patch)
-
-        # We push out this change.
-        push_patch(patch)
-
-        # Because there should be no patch queues, we expect that the ref count remains
-        # the same. If the ref count had increased, then we would know that the patch
-        # queue has not been cleaned up and that the patch we just pushed was added to
-        # it.
-        assert not sys.getrefcount(patch) > patch_ref_count
-
-
 async def test_dispatcher_handles_more_than_one_event_at_a_time():
     block_and_never_set = asyncio.Event()
     will_block = asyncio.Event()

tests/test_server/test_common/test_per_client_state.py renamed to tests/test_server/test_common.py

@@ -1,25 +1,13 @@
 import pytest
 
 import idom
-from idom.server import fastapi as idom_fastapi
-from idom.server import flask as idom_flask
-from idom.server import sanic as idom_sanic
-from idom.server import starlette as idom_starlette
-from idom.server import tornado as idom_tornado
+from idom.server.utils import all_implementations
 from idom.testing import ServerFixture
 
 
 @pytest.fixture(
-    params=[
-        # add new PerClientStateServer implementations here to
-        # run a suite of tests which check basic functionality
-        idom_fastapi.PerClientStateServer,
-        idom_flask.PerClientStateServer,
-        idom_sanic.PerClientStateServer,
-        idom_starlette.PerClientStateServer,
-        idom_tornado.PerClientStateServer,
-    ],
-    ids=lambda cls: f"{cls.__module__}.{cls.__name__}",
+    params=list(all_implementations()),
+    ids=lambda imp: imp.__name__,
 )
 def server_mount_point(request):
     with ServerFixture(request.param) as mount_point:

tests/test_server/test_common/__init__.py

@@ -2,21 +2,7 @@
 
 import pytest
 
-from idom.server.utils import find_available_port, poll, wait_on_event
-
-
-def test_poll():
-    with pytest.raises(TimeoutError, match="Did not do something within 0.1 seconds"):
-        poll("do something", 0.01, 0.1, lambda: False)
-    poll("do something", 0.01, None, [True, False, False].pop)
-
-
-def test_wait_on_event():
-    event = Event()
-    with pytest.raises(TimeoutError, match="Did not do something within 0.1 seconds"):
-        wait_on_event("do something", event, 0.1)
-    event.set()
-    wait_on_event("do something", event, None)
+from idom.server.utils import find_available_port
 
 
 def test_find_available_port():