Skip to content

Update CompiledRoute.resolve to return a dataclass, not a tuple #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Archmonger opened this issue Oct 18, 2024 · 0 comments · Fixed by #51
Closed

Update CompiledRoute.resolve to return a dataclass, not a tuple #38

Archmonger opened this issue Oct 18, 2024 · 0 comments · Fixed by #51
Labels
complexity: 3 (low) priority: 1 (high) type: revision

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Oct 18, 2024 •
edited
Loading

Current Situation

CompiledRoute.resolve currently returns a tuple, but we should rewrite it in a more robust way.

Proposed Actions

Utilize a dataclass instead of a tuple. This could potentially be named MatchedRoute.

This dataclass should contain the following attributes: element, parameters, path.

Related issue: #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity: 3 (low) priority: 1 (high) type: revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom router API Archmonger/reactpy-router
1 participant
@Archmonger