Skip to content

Add Type Checking To This Project And Add py.typed #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmorshea opened this issue Jul 15, 2022 · 2 comments · Fixed by #86 or #81
Closed

Add Type Checking To This Project And Add py.typed #91

rmorshea opened this issue Jul 15, 2022 · 2 comments · Fixed by #86 or #81
Labels
priority: 3 (low)

Comments

@rmorshea
Copy link
Contributor

rmorshea commented Jul 15, 2022 •
edited
Loading

Current Situation

Right now, we don't do any type checking with MyPy. We also do not distribute a py.typed marker file which would allow MyPy to work with django_idom when it's installed in other projects.

Proposed Actions

  • Add type checking with mypy. Preferably we'd eventually check in --strict mode, but we don't have to start there.
  • Distribute a py.typed marker file.
@Archmonger
Copy link
Contributor

What's the benefit of MyPy over stdlib type hints?

@rmorshea
Copy link
Contributor Author

MyPy is just the type checker. All the type hints will stay the same.

This was linked to pull requests Sep 14, 2022
use_query and use_mutation #86
Merged
View to Component #81
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: 3 (low)
Projects
None yet
Milestone
No milestone
2 participants
@rmorshea @Archmonger