Skip to content

Commit 8531c04

Browse files
authored
Fix Python and docs tests (#250)
- Fix python tests failures caused by upgraded mypy stubs - Switch `linkcheckmd` to it's replacement `linkspector`
1 parent 9b36b6d commit 8531c04

File tree

5 files changed

+15
-5
lines changed

5 files changed

+15
-5
lines changed

.github/workflows/test-docs.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,15 @@ jobs:
2020
- uses: actions/setup-python@v5
2121
with:
2222
python-version: 3.x
23+
- name: Check docs links
24+
uses: umbrelladocs/action-linkspector@v1
25+
with:
26+
github_token: ${{ secrets.github_token }}
27+
reporter: github-pr-review
28+
fail_on_error: true
2329
- name: Check docs build
2430
run: |
2531
pip install -r requirements/build-docs.txt
26-
linkcheckMarkdown docs/ -v -r
27-
linkcheckMarkdown README.md -v -r
28-
linkcheckMarkdown CHANGELOG.md -v -r
2932
cd docs
3033
mkdocs build --strict
3134
- name: Check docs examples

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ venv.bak/
101101

102102
# mkdocs documentation
103103
/site
104+
docs/site
104105

105106
# mypy
106107
.mypy_cache/

.linkspector.yml

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
dirs:
2+
- ./docs
3+
files:
4+
- README.md
5+
- CHANGELOG.md
6+
useGitIgnore: true
7+
modifiedFilesOnly: false

requirements/build-docs.txt

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ mkdocs
22
mkdocs-git-revision-date-localized-plugin
33
mkdocs-material==9.4.0
44
mkdocs-include-markdown-plugin
5-
linkcheckmd
65
mkdocs-spellcheck[all]
76
mkdocs-git-authors-plugin
87
mkdocs-minify-plugin

src/reactpy_django/clean.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def clean_user_data(verbosity: int = 1):
8787
start_time = timezone.now()
8888
user_model = get_user_model()
8989
all_users = user_model.objects.all()
90-
all_user_pks = all_users.values_list(user_model._meta.pk.name, flat=True) # type: ignore
90+
all_user_pks = all_users.values_list(user_model._meta.pk.name, flat=True)
9191

9292
# Django doesn't support using QuerySets as an argument with cross-database relations.
9393
if user_model.objects.db != UserDataModel.objects.db:

0 commit comments

Comments
 (0)