Fix render loop bug

Author: Archmonger

src/reactpy_django/forms/components.py

@@ -42,10 +42,6 @@ def _django_form(
     top_children: Sequence,
     bottom_children: Sequence,
 ):
-    # TODO: Implement form restoration on page reload. Maybe this involves creating a new setting called
-    # `form_restoration_method` that can be set to "URL", "CLIENT_STORAGE", "SERVER_SESSION", or None.
-    # Perhaps pre-rendering is robust enough already handle this scenario?
-    # Additionally, "URL" mode would limit the user to one form per page.
     # TODO: Test this with django-colorfield, django-ace, django-crispy-forms
     uuid_ref = hooks.use_ref(uuid4().hex.replace("-", ""))
     top_children_count = hooks.use_ref(len(top_children))
@@ -86,7 +82,9 @@ async def render_form():
                 await database_sync_to_async(initialized_form.save)()
                 set_submitted_data(None)
 
-        set_rendered_form(await database_sync_to_async(initialized_form.render)(form_template))
+        new_form = await database_sync_to_async(initialized_form.render)(form_template)
+        if new_form != rendered_form:
+            set_rendered_form(new_form)
 
     def _on_change(_event):
         if on_change:

tests/test_app/forms/forms.py

@@ -1,5 +1,4 @@
 from django import forms
-from django.forms import ModelForm
 
 from .. import models
 
@@ -45,15 +44,14 @@ class BasicForm(forms.Form):
     model_multiple_choice_field = forms.ModelMultipleChoiceField(
         label="model multiple choice field", initial="1", queryset=models.TodoItem.objects.all()
     )
-
     # Currently unsupported fields
     # multi_value_field = MultiValueField(label="multi value", initial="[email protected]")
     # split_datetime_field = forms.SplitDateTimeField(label="split datetime")
     # file_field = forms.FileField(label="file")
     # image_field = forms.ImageField(label="image")
 
 
-class DatabaseBackedForm(ModelForm):
+class DatabaseBackedForm(forms.ModelForm):
     class Meta:
         model = models.TodoItem
         fields = "__all__"