Skip to content

Commit 2fad88c

Browse files
committed
Misc code cleanup
1 parent 2e6bf21 commit 2fad88c

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/reactpy_django/hooks.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
)
1616
from uuid import uuid4
1717

18-
import orjson as pickle
18+
import orjson
1919
from channels import DEFAULT_CHANNEL_LAYER
2020
from channels.db import database_sync_to_async
2121
from channels.layers import InMemoryChannelLayer, get_channel_layer
@@ -351,7 +351,7 @@ async def _set_user_data(data: dict):
351351

352352
pk = get_pk(user)
353353
model, _ = await UserDataModel.objects.aget_or_create(user_pk=pk)
354-
model.data = pickle.dumps(data)
354+
model.data = orjson.dumps(data)
355355
await model.asave()
356356

357357
query: Query[dict | None] = use_query(
@@ -471,7 +471,7 @@ async def _get_user_data(
471471

472472
pk = get_pk(user)
473473
model, _ = await UserDataModel.objects.aget_or_create(user_pk=pk)
474-
data = pickle.loads(model.data) if model.data else {}
474+
data = orjson.loads(model.data) if model.data else {}
475475

476476
if not isinstance(data, dict):
477477
raise TypeError(f"Expected dict while loading user data, got {type(data)}")

src/reactpy_django/models.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
from django.db.models.signals import pre_delete
44
from django.dispatch import receiver
55

6+
from reactpy_django.utils import get_pk
7+
68

79
class ComponentSession(models.Model):
810
"""A model for storing component sessions."""
@@ -41,6 +43,6 @@ class UserDataModel(models.Model):
4143
@receiver(pre_delete, sender=get_user_model(), dispatch_uid="reactpy_delete_user_data")
4244
def delete_user_data(sender, instance, **kwargs):
4345
"""Delete ReactPy's `UserDataModel` when a Django `User` is deleted."""
44-
pk = getattr(instance, instance._meta.pk.name)
46+
pk = get_pk(instance)
4547

4648
UserDataModel.objects.filter(user_pk=pk).delete()

src/reactpy_django/router/resolvers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def parse_path(path: str) -> tuple[re.Pattern[str], ConverterMapping]:
5252
pattern += f"{re.escape(path[last_match_end:])}$"
5353

5454
# Replace literal `*` with "match anything" regex pattern, if it's at the end of the path
55-
if pattern.endswith("\*$"):
55+
if pattern.endswith(r"\*$"):
5656
pattern = f"{pattern[:-3]}.*$"
5757

5858
return re.compile(pattern), converters

0 commit comments

Comments
 (0)