Handle all pyright warnings

Author: Archmonger

docs/examples/python/example/models.py

@@ -0,0 +1,4 @@
+from django.db import models
+
+
+class TodoItem(models.Model): ...

src/reactpy_django/clean.py

@@ -84,7 +84,7 @@ def clean_user_data(verbosity: int = 1):
     start_time = timezone.now()
     user_model = get_user_model()
     all_users = user_model.objects.all()
-    all_user_pks = all_users.values_list(user_model._meta.pk.name, flat=True)
+    all_user_pks = all_users.values_list(user_model._meta.pk.name, flat=True)  # type: ignore
 
     # Django doesn't support using QuerySets as an argument with cross-database relations.
     if user_model.objects.db != UserDataModel.objects.db:

src/reactpy_django/components.py

@@ -32,14 +32,14 @@
     from django.forms import Form, ModelForm
     from django.views import View
 
-    from reactpy_django.types import AsyncFormEvent, SyncFormEvent
+    from reactpy_django.types import AsyncFormEvent, SyncFormEvent, ViewToComponentConstructor, ViewToIframeConstructor
 
 
 def view_to_component(
     view: Callable | View | str,
     transforms: Sequence[Callable[[VdomDict], Any]] = (),
     strict_parsing: bool = True,
-) -> Any:
+) -> ViewToComponentConstructor:
     """Converts a Django view to a ReactPy component.
 
     Keyword Args:
@@ -58,7 +58,7 @@ def constructor(
         *args,
         key: Key | None = None,
         **kwargs,
-    ):
+    ) -> ComponentType:
         return _view_to_component(
             view=view,
             transforms=transforms,
@@ -72,7 +72,7 @@ def constructor(
     return constructor
 
 
-def view_to_iframe(view: Callable | View | str, extra_props: dict[str, Any] | None = None):
+def view_to_iframe(view: Callable | View | str, extra_props: dict[str, Any] | None = None) -> ViewToIframeConstructor:
     """
     Args:
         view: The view function or class to convert, or the dotted path to the view.
@@ -88,13 +88,13 @@ def constructor(
         *args,
         key: Key | None = None,
         **kwargs,
-    ):
+    ) -> ComponentType:
         return _view_to_iframe(view=view, extra_props=extra_props, args=args, kwargs=kwargs, key=key)
 
     return constructor
 
 
-def django_css(static_path: str, key: Key | None = None):
+def django_css(static_path: str, key: Key | None = None) -> ComponentType:
     """Fetches a CSS static file for use within ReactPy. This allows for deferred CSS loading.
 
     Args:
@@ -107,7 +107,7 @@ def django_css(static_path: str, key: Key | None = None):
     return _django_css(static_path=static_path, key=key)
 
 
-def django_js(static_path: str, key: Key | None = None):
+def django_js(static_path: str, key: Key | None = None) -> ComponentType:
     """Fetches a JS static file for use within ReactPy. This allows for deferred JS loading.
 
     Args:
@@ -135,7 +135,7 @@ def django_form(
     top_children: Sequence[Any] = (),
     bottom_children: Sequence[Any] = (),
     key: Key | None = None,
-):
+) -> ComponentType:
     """Converts a Django form to a ReactPy component.
 
     Args:
@@ -182,7 +182,7 @@ def pyscript_component(
     *file_paths: str,
     initial: str | VdomDict | ComponentType = "",
     root: str = "root",
-):
+) -> ComponentType:
     """
     Args:
         file_paths: File path to your client-side component. If multiple paths are \
@@ -219,7 +219,7 @@ def _view_to_component(
     else:
         _request = HttpRequest()
         _request.method = "GET"
-    resolved_view: Callable = import_module(view) if isinstance(view, str) else view
+    resolved_view: Callable = import_module(view) if isinstance(view, str) else view  # type: ignore
 
     # Render the view render within a hook
     @hooks.use_effect(
@@ -251,12 +251,12 @@ def _view_to_iframe(
     extra_props: dict[str, Any] | None,
     args: Sequence,
     kwargs: dict,
-) -> VdomDict:
+):
     """The actual component. Used to prevent pollution of acceptable kwargs keys."""
     from reactpy_django.config import REACTPY_REGISTERED_IFRAME_VIEWS
 
     if hasattr(view, "view_class"):
-        view = view.view_class
+        view = view.view_class  # type: ignore
     dotted_path = view if isinstance(view, str) else generate_obj_name(view)
     registered_view = REACTPY_REGISTERED_IFRAME_VIEWS.get(dotted_path)
 

src/reactpy_django/decorators.py

@@ -35,10 +35,10 @@ def _wrapper(*args, **kwargs):
 
         return _wrapper
 
-    return decorator
+    return decorator  # type: ignore
 
 
-@component
+@component  # type: ignore
 def _user_passes_test(component_constructor, fallback, test_func, *args, **kwargs):
     """Dedicated component for `user_passes_test` to allow us to always have access to hooks."""
     user = use_user()

src/reactpy_django/forms/transforms.py

@@ -1,3 +1,4 @@
+# type: ignore
 # TODO: Almost everything in this module should be moved to `reactpy.utils._mutate_vdom()`.
 from __future__ import annotations
 

src/reactpy_django/hooks.py

@@ -3,6 +3,7 @@
 import asyncio
 import logging
 from collections import defaultdict
+from collections.abc import Awaitable
 from typing import (
     TYPE_CHECKING,
     Any,
@@ -36,7 +37,7 @@
 from reactpy_django.utils import django_query_postprocessor, ensure_async, generate_obj_name, get_pk
 
 if TYPE_CHECKING:
-    from collections.abc import Awaitable, Sequence
+    from collections.abc import Sequence
 
     from channels_redis.core import RedisChannelLayer
     from django.contrib.auth.models import AbstractUser
@@ -137,13 +138,17 @@ async def execute_query() -> None:
         """The main running function for `use_query`"""
         try:
             # Run the query
-            new_data = await ensure_async(query, thread_sensitive=thread_sensitive)(**kwargs)
+            query_async = cast(
+                Callable[..., Awaitable[Inferred]], ensure_async(query, thread_sensitive=thread_sensitive)
+            )
+            new_data = await query_async(**kwargs)
 
             # Run the postprocessor
             if postprocessor:
-                new_data = await ensure_async(postprocessor, thread_sensitive=thread_sensitive)(
-                    new_data, **postprocessor_kwargs
+                async_postprocessor = cast(
+                    Callable[..., Awaitable[Any]], ensure_async(postprocessor, thread_sensitive=thread_sensitive)
                 )
+                new_data = await async_postprocessor(new_data, **postprocessor_kwargs)
 
         # Log any errors and set the error state
         except Exception as e:
@@ -230,7 +235,7 @@ def use_mutation(
     async_task_refs = use_ref(set())
 
     # The main "running" function for `use_mutation`
-    async def execute_mutation(exec_args, exec_kwargs) -> None:
+    async def execute_mutation(*exec_args: FuncParams.args, **exec_kwargs: FuncParams.kwargs) -> None:
         # Run the mutation
         try:
             should_refetch = await ensure_async(mutation, thread_sensitive=thread_sensitive)(*exec_args, **exec_kwargs)
@@ -262,7 +267,7 @@ def schedule_mutation(*exec_args: FuncParams.args, **exec_kwargs: FuncParams.kwa
         set_loading(True)
 
         # Execute the mutation in the background
-        task = asyncio.ensure_future(execute_mutation(exec_args=exec_args, exec_kwargs=exec_kwargs))
+        task = asyncio.ensure_future(execute_mutation(*exec_args, **exec_kwargs))
 
         # Add the task to a set to prevent it from being garbage collected
         async_task_refs.current.add(task)
@@ -359,7 +364,7 @@ def use_channel_layer(
         layer: The channel layer to use. This layer must be defined in \
             `settings.py:CHANNEL_LAYERS`.
     """
-    channel_layer: InMemoryChannelLayer | RedisChannelLayer = get_channel_layer(layer)
+    channel_layer: InMemoryChannelLayer | RedisChannelLayer = get_channel_layer(layer)  # type: ignore
     channel_name = use_memo(lambda: str(name or uuid4()))
 
     if not name and not group_name:

src/reactpy_django/http/views.py

@@ -8,7 +8,7 @@
 from reactpy_django.utils import FileAsyncIterator, render_view
 
 
-def web_modules_file(request: HttpRequest, file: str) -> HttpResponse:
+def web_modules_file(request: HttpRequest, file: str) -> FileResponse:
     """Gets JavaScript required for ReactPy modules at runtime."""
 
     web_modules_dir = REACTPY_WEB_MODULES_DIR.current

src/reactpy_django/pyscript/layout_handler.py

@@ -1,3 +1,4 @@
+# type: ignore
 import asyncio
 import logging
 

src/reactpy_django/types.py

@@ -13,7 +13,7 @@
 )
 
 from django.http import HttpRequest
-from reactpy.types import Connection
+from reactpy.types import ComponentType, Connection, Key
 from typing_extensions import ParamSpec
 
 if TYPE_CHECKING:
@@ -98,3 +98,13 @@ async def __call__(self, message: dict) -> None: ...
 
 class AsyncMessageSender(Protocol):
     async def __call__(self, message: dict) -> None: ...
+
+
+class ViewToComponentConstructor(Protocol):
+    def __call__(
+        self, request: HttpRequest | None = None, *args: Any, key: Key | None = None, **kwargs: Any
+    ) -> ComponentType: ...
+
+
+class ViewToIframeConstructor(Protocol):
+    def __call__(self, *args: Any, key: Key | None = None, **kwargs: Any) -> ComponentType: ...

src/reactpy_django/utils.py

@@ -80,10 +80,10 @@ async def render_view(
     """Ingests a Django view (class or function) and returns an HTTP response object."""
     # Convert class-based view to function-based view
     if getattr(view, "as_view", None):
-        view = view.as_view()
+        view = view.as_view()  # type: ignore
 
     # Sync/Async function view
-    response = await ensure_async(view)(request, *args, **kwargs)
+    response = await ensure_async(view)(request, *args, **kwargs)  # type: ignore
 
     # TemplateView needs an extra render step
     if getattr(response, "render", None):
@@ -122,7 +122,7 @@ def register_iframe(view: Callable | View | str):
     from reactpy_django.config import REACTPY_REGISTERED_IFRAME_VIEWS
 
     if hasattr(view, "view_class"):
-        view = view.view_class
+        view = view.view_class  # type: ignore
     dotted_path = view if isinstance(view, str) else generate_obj_name(view)
     try:
         REACTPY_REGISTERED_IFRAME_VIEWS[dotted_path] = import_dotted_path(dotted_path)
@@ -165,7 +165,7 @@ def get_loaders(self):
         template_source_loaders = []
         for e in engines.all():
             if hasattr(e, "engine"):
-                template_source_loaders.extend(e.engine.get_template_loaders(e.engine.loaders))
+                template_source_loaders.extend(e.engine.get_template_loaders(e.engine.loaders))  # type: ignore
         loaders = []
         for loader in template_source_loaders:
             if hasattr(loader, "loaders"):
@@ -366,7 +366,7 @@ def __enter__(self):
     def __exit__(self, *_):
         async_to_sync(self.__aexit__)(*_)
 
-    def render(self):
+    def sync_render(self):
         return async_to_sync(super().render)()
 
 
@@ -413,9 +413,9 @@ def prerender_component(
             ),
         )
     ) as layout:
-        vdom_tree = layout.render()["model"]
+        vdom_tree = layout.sync_render()["model"]
 
-    return vdom_to_html(vdom_tree)
+    return vdom_to_html(vdom_tree)  # type: ignore
 
 
 def vdom_or_component_to_string(
@@ -424,7 +424,7 @@ def vdom_or_component_to_string(
     """Converts a VdomDict or component to an HTML string. If a string is provided instead, it will be
     automatically returned."""
     if isinstance(vdom_or_component, dict):
-        return vdom_to_html(vdom_or_component)
+        return vdom_to_html(vdom_or_component)  # type: ignore
 
     if hasattr(vdom_or_component, "render"):
         if not request:
@@ -536,17 +536,16 @@ def __init__(self, file_path: str):
         self.file_path = file_path
 
     async def __aiter__(self):
-        file_opened = False
+        file_handle = None
         try:
             file_handle = FILE_ASYNC_ITERATOR_THREAD.submit(open, self.file_path, "rb").result()
-            file_opened = True
             while True:
                 chunk = FILE_ASYNC_ITERATOR_THREAD.submit(file_handle.read, 8192).result()
                 if not chunk:
                     break
                 yield chunk
         finally:
-            if file_opened:
+            if file_handle:
                 file_handle.close()
 
 

src/reactpy_django/websocket/consumer.py

@@ -16,8 +16,8 @@
 from channels.auth import login
 from channels.generic.websocket import AsyncJsonWebsocketConsumer
 from django.utils import timezone
-from reactpy.backend.hooks import ConnectionContext
 from reactpy.backend.types import Connection, Location
+from reactpy.core.hooks import ConnectionContext
 from reactpy.core.layout import Layout
 from reactpy.core.serve import serve_layout
 
@@ -210,7 +210,7 @@ async def run_dispatcher(self):
         # Start the ReactPy component rendering loop
         with contextlib.suppress(Exception):
             await serve_layout(
-                Layout(ConnectionContext(root_component, value=connection)),
+                Layout(ConnectionContext(root_component, value=connection)),  # type: ignore
                 self.send_json,
                 self.recv_queue.get,
             )

src/reactpy_django/websocket/paths.py

@@ -5,7 +5,7 @@
 
 REACTPY_WEBSOCKET_ROUTE = path(
     f"{REACTPY_URL_PREFIX}/<str:dotted_path>/<uuid:uuid>/<int:has_args>/",
-    ReactpyAsyncWebsocketConsumer.as_asgi(),
+    ReactpyAsyncWebsocketConsumer.as_asgi(),  # type: ignore
 )
 """A URL path for :class:`ReactpyAsyncWebsocketConsumer`.