Skip to content

Commit 0ff84ec

Browse files
committed
make logger private
1 parent 3e07d5a commit 0ff84ec

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/django_idom/app_components.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from .app_settings import IDOM_IGNORE_INSTALLED_APPS
99

1010

11-
logger = logging.getLogger(__name__)
11+
_logger = logging.getLogger(__name__)
1212
_LOADED_COMPONENTS: Dict[str, ComponentConstructor] = {}
1313

1414

@@ -22,19 +22,19 @@ def has_component(name: str) -> bool:
2222

2323
for app_mod_name in settings.INSTALLED_APPS:
2424
if app_mod_name in IDOM_IGNORE_INSTALLED_APPS:
25-
logger.debug(f"{app_mod_name!r} skipped by IDOM_IGNORE_INSTALLED_APPS")
25+
_logger.debug(f"{app_mod_name!r} skipped by IDOM_IGNORE_INSTALLED_APPS")
2626
continue
2727

2828
idom_mod_name = f"{app_mod_name}.idom"
2929

3030
try:
3131
idom_mod = import_module(idom_mod_name)
3232
except ImportError:
33-
logger.debug(f"Skipping {idom_mod_name!r} - does not exist")
33+
_logger.debug(f"Skipping {idom_mod_name!r} - does not exist")
3434
continue
3535

3636
if not hasattr(idom_mod, "components"):
37-
logger.warning(
37+
_logger.warning(
3838
f"'django_idom' expected module {idom_mod_name!r} to have an "
3939
"'components' attribute that lists its publically available components."
4040
)

src/django_idom/websocket_consumer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from .app_components import get_component, has_component
1313

1414

15-
logger = logging.getLogger(__name__)
15+
_logger = logging.getLogger(__name__)
1616

1717

1818
class IdomAsyncWebSocketConsumer(AsyncJsonWebsocketConsumer):
@@ -39,7 +39,7 @@ async def _run_dispatch_loop(self):
3939
view_id = self.scope["url_route"]["kwargs"]["view_id"]
4040

4141
if not has_component(view_id):
42-
logger.warning(f"Uknown IDOM view ID {view_id!r}")
42+
_logger.warning(f"Uknown IDOM view ID {view_id!r}")
4343
return
4444

4545
component_constructor = get_component(view_id)
@@ -50,7 +50,7 @@ async def _run_dispatch_loop(self):
5050
try:
5151
component_instance = component_constructor(**component_kwargs)
5252
except Exception:
53-
logger.exception(
53+
_logger.exception(
5454
f"Failed to construct component {component_constructor} "
5555
f"with parameters {component_kwargs}"
5656
)

0 commit comments

Comments
 (0)