Skip to content

Commit fc52bca

Browse files
authored
fix: Remove explicit SDK version for Windows builds (#483)
* Remove explicit SDK version See react-native-async-storage/async-storage#810 Update SDK logic based on PR feedback * Update Cpp.Default.props order per feedback
1 parent ad63d4e commit fc52bca

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

windows/ReactNativePicker/ReactNativePicker.vcxproj

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,16 @@
1414
<AppContainerApplication>true</AppContainerApplication>
1515
<ApplicationType>Windows Store</ApplicationType>
1616
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
17-
<WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.18362.0</WindowsTargetPlatformVersion>
18-
<WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion>
1917
</PropertyGroup>
20-
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
2118
<PropertyGroup Label="ReactNativeWindowsProps">
2219
<ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir>
2320
</PropertyGroup>
21+
<Import Project="$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.WindowsSdk.Default.props" Condition="Exists('$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.WindowsSdk.Default.props')" />
22+
<PropertyGroup Label="Fallback Windows SDK Versions">
23+
<WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.18362.0</WindowsTargetPlatformVersion>
24+
<WindowsTargetPlatformMinVersion Condition=" '$(WindowsTargetPlatformMinVersion)' == '' ">10.0.17763.0</WindowsTargetPlatformMinVersion>
25+
</PropertyGroup>
26+
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
2427
<ItemGroup Label="ProjectConfigurations">
2528
<ProjectConfiguration Include="Debug|ARM">
2629
<Configuration>Debug</Configuration>

0 commit comments

Comments
 (0)