Skip to content

Warning: deep-assign is deprecated #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yvbeek opened this issue May 27, 2020 · 5 comments · Fixed by #657
Closed

Warning: deep-assign is deprecated #374

yvbeek opened this issue May 27, 2020 · 5 comments · Fixed by #657
Labels
help wanted :octocat: platform: web This is web specific

Comments

@yvbeek
Copy link

yvbeek commented May 27, 2020

warning @react-native-community/async-storage > [email protected]: Check out lodash.merge or merge-options instead.

We can probably swap out the deep-assign library with one of these:

https://github.com/TehShrike/deepmerge
https://github.com/schnittstabil/merge-options

Only seems to be used here?
https://github.com/react-native-community/async-storage/blob/85c5278534eef549a959ae386bd0e16fdb0167b0/src/AsyncStorage.js#L17

@krizzu
Copy link
Member

krizzu commented Jun 18, 2020

Hey,

This is great first-time contribution task - I can provide help with implementing it.

@tido64
Copy link
Member

tido64 commented Oct 14, 2020

@krizzu: Are we still doing this?

@tido64 tido64 added the platform: web This is web specific label Oct 15, 2020
@krizzu
Copy link
Member

krizzu commented Oct 15, 2020

We rely on the library that has its quirks, so upgrading means we could potentially break already released versions.

@github-actions
Copy link

This issue has been marked as stale due to inactivity. Please respond or otherwise resolve the issue within 7 days or it will be closed.

@krizzu
Copy link
Member

krizzu commented Aug 16, 2021

🎉 This issue has been resolved in version 1.15.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted :octocat: platform: web This is web specific
Projects
None yet
3 participants