Skip to content

Update to work with react-router v7 #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikeycoxon opened this issue Jan 15, 2025 · 2 comments
Open

Update to work with react-router v7 #326

mikeycoxon opened this issue Jan 15, 2025 · 2 comments

Comments

@mikeycoxon
Copy link

It a simple matter to make a version of this library with react router v7.

basically, its change the peer dependency from react-router-dom to react-router

and import that at the top of LinkContainer.js, as in:

import { useHref, useLocation, useMatch, useNavigate } from 'react-router';

everything else seems to work just fine. Two reasons why I didn't submit this as a PR were:

  1. didn't know if I had the privileges
  2. this would be a breaking change for anyone still reliant on react-routeer v6 (and therefore react-router-dom)

maybe publish a variant?

@segagnon-bell
Copy link

Hi,

I am facing the same problem today. I find multiple threads about it in the issues here, but no one seems to be actioning them.

Who is the maintainer on this package ? Who can we contact to get the ball rolling ?

@bkt0031
Copy link

bkt0031 commented May 2, 2025

Same issue here as well. I'm experiencing the same error as #322 where I validated in my code that LinkContainer was indeed within the component. I tried to use a fork of this repository where the above fix was applied, but with react-router v7.5.x it still failed with the same response. My fix was to downgrade react-router-dom to v6.16.0 which is what I was using in my old code branch before I embarked on this whole Node.JS module refresh effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants