Skip to content

Commit 48e698b

Browse files
Debian Science Teamrebecca-palmer
Debian Science Team
authored andcommitted
Fix test failures when xlsxwriter is not installed
Author: Rebecca N. Palmer <[email protected]> Forwarded: no Gbp-Pq: Name 2p1_openpyxl_errors.patch
1 parent 2f85577 commit 48e698b

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

pandas/tests/io/excel/test_openpyxl.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,13 +124,14 @@ def test_engine_kwargs_append_invalid(ext):
124124
DataFrame(["good"]).to_excel(writer, sheet_name="Sheet2")
125125

126126

127+
@td.skip_if_no("xlsxwriter")
127128
@pytest.mark.parametrize("data_only, expected", [(True, 0), (False, "=1+1")])
128129
def test_engine_kwargs_append_data_only(ext, data_only, expected):
129130
# GH 43445
130131
# tests whether the data_only engine_kwarg actually works well for
131132
# openpyxl's load_workbook
132133
with tm.ensure_clean(ext) as f:
133-
DataFrame(["=1+1"]).to_excel(f)
134+
DataFrame(["=1+1"]).to_excel(f, engine="xlsxwriter") # with openpyxl here, data_only=True gives None/np.nan not 0
134135
with ExcelWriter(
135136
f, engine="openpyxl", mode="a", engine_kwargs={"data_only": data_only}
136137
) as writer:

pandas/tests/io/excel/test_writers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1420,6 +1420,8 @@ def test_ExcelWriter_dispatch(self, klass, ext):
14201420
assert isinstance(writer, _XlsxWriter)
14211421
else:
14221422
assert isinstance(writer, klass)
1423+
# openpyxl raises on closing if no sheets are written
1424+
DataFrame().to_excel(writer, sheet_name="Sheet1")
14231425

14241426
def test_ExcelWriter_dispatch_raises(self):
14251427
with pytest.raises(ValueError, match="No engine"):

0 commit comments

Comments
 (0)