Skip to content

Commit 8c20d2a

Browse files
authored
Add condition for test_groupby_nulls_basic in pandas 2.2 (#15072)
This case for some reason doesn't raise a FutureWarning in pandas in 2.2 while it does in pandas 2.1. It's likely a won't-fix so adding a condition Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Michael Wang (https://github.com/isVoid) URL: #15072
1 parent 6a9cefd commit 8c20d2a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

python/cudf/cudf/tests/test_groupby.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1433,7 +1433,7 @@ def test_groupby_nulls_basic(agg):
14331433

14341434
# TODO: fillna() used here since we don't follow
14351435
# Pandas' null semantics. Should we change it?
1436-
with expect_warning_if(agg in {"idxmax", "idxmin"}):
1436+
with expect_warning_if(agg in {"idxmax", "idxmin"} and not PANDAS_GE_220):
14371437
assert_groupby_results_equal(
14381438
getattr(pdf.groupby("a"), agg)().fillna(0),
14391439
getattr(gdf.groupby("a"), agg)().fillna(0 if agg != "prod" else 1),

0 commit comments

Comments
 (0)