Skip to content

Commit 3df4ac2

Browse files
authored
Remove squeeze argument from groupby (#16312)
In pandas, this argument was deprecated in pandas 1.x and removed in pandas 2.x. xref pandas-dev/pandas#33218 Looks like in cudf this argument was never implemented, so to align with pandas, I think it should be OK to just remove this argument Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #16312
1 parent cb570fe commit 3df4ac2

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

python/cudf/cudf/core/dataframe.py

-2
Original file line numberDiff line numberDiff line change
@@ -4306,7 +4306,6 @@ def groupby(
43064306
as_index=True,
43074307
sort=no_default,
43084308
group_keys=False,
4309-
squeeze=False,
43104309
observed=True,
43114310
dropna=True,
43124311
):
@@ -4317,7 +4316,6 @@ def groupby(
43174316
as_index,
43184317
sort,
43194318
group_keys,
4320-
squeeze,
43214319
observed,
43224320
dropna,
43234321
)

python/cudf/cudf/core/indexed_frame.py

-6
Original file line numberDiff line numberDiff line change
@@ -5249,7 +5249,6 @@ def groupby(
52495249
as_index=True,
52505250
sort=no_default,
52515251
group_keys=False,
5252-
squeeze=False,
52535252
observed=True,
52545253
dropna=True,
52555254
):
@@ -5259,11 +5258,6 @@ def groupby(
52595258
if axis not in (0, "index"):
52605259
raise NotImplementedError("axis parameter is not yet implemented")
52615260

5262-
if squeeze is not False:
5263-
raise NotImplementedError(
5264-
"squeeze parameter is not yet implemented"
5265-
)
5266-
52675261
if not observed:
52685262
raise NotImplementedError(
52695263
"observed parameter is not yet implemented"

python/cudf/cudf/core/series.py

-2
Original file line numberDiff line numberDiff line change
@@ -3368,7 +3368,6 @@ def groupby(
33683368
as_index=True,
33693369
sort=no_default,
33703370
group_keys=False,
3371-
squeeze=False,
33723371
observed=True,
33733372
dropna=True,
33743373
):
@@ -3379,7 +3378,6 @@ def groupby(
33793378
as_index,
33803379
sort,
33813380
group_keys,
3382-
squeeze,
33833381
observed,
33843382
dropna,
33853383
)

0 commit comments

Comments
 (0)