Skip to content

Commit 077eec4

Browse files
authored
xfail test_join_ordering_pandas_compat for pandas 2.2 (#15080)
Right merge is implement by swapping left and right and performing a left merge, but the result ordering of columns that are named similarly changed in pandas 2.2 and I cannot currently narrow down when pandas orders the resulting columns a certain way. Since the merge is still technically correct besides a column ordering, just going to xfail this case for now and have it as a follow up. Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #15080
1 parent 634b4cb commit 077eec4

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

python/cudf/cudf/tests/test_join_order.py

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2023, NVIDIA CORPORATION.
1+
# Copyright (c) 2023-2024, NVIDIA CORPORATION.
22

33
import itertools
44
import operator
@@ -155,7 +155,13 @@ def expected(left, right, sort, *, how):
155155

156156

157157
@pytest.mark.parametrize("how", ["inner", "left", "right", "outer"])
158-
def test_join_ordering_pandas_compat(left, right, sort, how):
158+
def test_join_ordering_pandas_compat(request, left, right, sort, how):
159+
request.applymarker(
160+
pytest.mark.xfail(
161+
PANDAS_GE_220 and how == "right",
162+
reason="TODO: Result ording of suffix'ed columns is incorrect",
163+
)
164+
)
159165
with cudf.option_context("mode.pandas_compatible", True):
160166
actual = left.merge(right, on="key", how=how, sort=sort)
161167
expect = expected(left, right, sort, how=how)

0 commit comments

Comments
 (0)