Merge pull request #230 from rabbitmq/allow-0-for-max-length-bytes

Allow 0 for --max-length-bytes option (no limit)

Author: acogoluegnes

src/main/java/com/rabbitmq/stream/perf/StreamPerfTest.java

@@ -224,7 +224,7 @@ public class StreamPerfTest implements Callable<Integer> {
 
   @CommandLine.Option(
       names = {"--max-length-bytes", "-mlb"},
-      description = "max size of created streams",
+      description = "max size of created streams, use 0 for no limit",
       defaultValue = "20gb",
       converter = Utils.ByteCapacityTypeConverter.class)
   private ByteCapacity maxLengthBytes;
@@ -976,10 +976,13 @@ public Integer call() throws Exception {
   private void createStream(Environment environment, String stream) {
     StreamCreator streamCreator =
         environment.streamCreator().stream(stream)
-            .maxLengthBytes(this.maxLengthBytes)
             .maxSegmentSizeBytes(this.maxSegmentSize)
             .leaderLocator(this.leaderLocator);
 
+    if (this.maxLengthBytes.toBytes() != 0) {
+      streamCreator.maxLengthBytes(this.maxLengthBytes);
+    }
+
     if (this.maxAge != null) {
       streamCreator.maxAge(this.maxAge);
     }

src/test/java/com/rabbitmq/stream/ByteCapacityTest.java

@@ -48,6 +48,12 @@ void fromOk(String value, long expectedValueInBytes) {
     assertThat(capacity.toString()).isEqualTo(value);
   }
 
+  @ValueSource(strings = {"0tb", "0gb", "0mb", "0kb", "0"})
+  @ParameterizedTest
+  void zero(String value) {
+    assertThat(ByteCapacity.from(value).toBytes()).isEqualTo(0);
+  }
+
   @ParameterizedTest
   @ValueSource(strings = {"100.0gb", "abc", "100.0", "-10gb", "10b"})
   void fromKo(String value) {