Skip to content

Commit 5afeb53

Browse files
committed
Return copy of replicas
1 parent 062a094 commit 5afeb53

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/main/java/com/rabbitmq/stream/impl/Client.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2263,9 +2263,12 @@ public Broker getLeader() {
22632263
return leader;
22642264
}
22652265

2266-
@SuppressFBWarnings("EI_EXPOSE_REP2")
22672266
public List<Broker> getReplicas() {
2268-
return replicas;
2267+
return this.replicas.isEmpty() ? Collections.emptyList() : new ArrayList<>(this.replicas);
2268+
}
2269+
2270+
boolean hasReplicas() {
2271+
return !this.replicas.isEmpty();
22692272
}
22702273

22712274
public String getStream() {

src/main/java/com/rabbitmq/stream/impl/ProducersCoordinator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ List<BrokerWrapper> findCandidateNodes(String stream, boolean forceLeader) {
224224
}
225225
candidates.add(new BrokerWrapper(leader, true));
226226

227-
if (!forceLeader && !streamMetadata.getReplicas().isEmpty()) {
227+
if (!forceLeader && streamMetadata.hasReplicas()) {
228228
candidates.addAll(
229229
streamMetadata.getReplicas().stream()
230230
.map(b -> new BrokerWrapper(b, false))

0 commit comments

Comments
 (0)