Use lambdas for *Listener objects

A proposal to use lambdas in listeners objects. Some callback
interfaces have been introduced when necessary (not necessary
for e.g. ShutdownListener). Lambdas are wrapped into the original
listener interfaces. Provide a simple test to experiment with the
API.

References #246

Author: acogoluegnes

src/main/java/com/rabbitmq/client/BlockedCallback.java

@@ -0,0 +1,27 @@
+// Copyright (c) 2017 Pivotal Software, Inc.  All rights reserved.
+//
+// This software, the RabbitMQ Java client library, is triple-licensed under the
+// Mozilla Public License 1.1 ("MPL"), the GNU General Public License version 2
+// ("GPL") and the Apache License version 2 ("ASL"). For the MPL, please see
+// LICENSE-MPL-RabbitMQ. For the GPL, please see LICENSE-GPL2.  For the ASL,
+// please see LICENSE-APACHE2.
+//
+// This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND,
+// either express or implied. See the LICENSE file for specific language governing
+// rights and limitations of this software.
+//
+// If you have any questions regarding licensing, please contact us at
+// [email protected].
+
+package com.rabbitmq.client;
+
+import java.io.IOException;
+
+/**
+ *
+ */
+public interface BlockedCallback {
+
+    void handle(String reason) throws IOException;
+
+}

src/main/java/com/rabbitmq/client/Channel.java

@@ -107,6 +107,8 @@ public interface Channel extends ShutdownNotifier {
      */
     void addReturnListener(ReturnListener listener);
 
+    ReturnListener addReturnListener(ReturnCallback returnCallback);
+
     /**
      * Remove a {@link ReturnListener}.
      * @param listener the listener to remove
@@ -126,6 +128,14 @@ public interface Channel extends ShutdownNotifier {
      */
     void addConfirmListener(ConfirmListener listener);
 
+    /**
+     *
+     * @param ackCallback
+     * @param nackCallback
+     * @return
+     */
+    ConfirmListener addConfirmListener(ConfirmCallback ackCallback, ConfirmCallback nackCallback);
+
     /**
      * Remove a {@link ConfirmListener}.
      * @param listener the listener to remove

src/main/java/com/rabbitmq/client/ConfirmCallback.java

@@ -0,0 +1,28 @@
+// Copyright (c) 2017 Pivotal Software, Inc.  All rights reserved.
+//
+// This software, the RabbitMQ Java client library, is triple-licensed under the
+// Mozilla Public License 1.1 ("MPL"), the GNU General Public License version 2
+// ("GPL") and the Apache License version 2 ("ASL"). For the MPL, please see
+// LICENSE-MPL-RabbitMQ. For the GPL, please see LICENSE-GPL2.  For the ASL,
+// please see LICENSE-APACHE2.
+//
+// This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND,
+// either express or implied. See the LICENSE file for specific language governing
+// rights and limitations of this software.
+//
+// If you have any questions regarding licensing, please contact us at
+// [email protected].
+
+
+package com.rabbitmq.client;
+
+import java.io.IOException;
+
+/**
+ *
+ */
+public interface ConfirmCallback {
+
+    void handle(long deliveryTag, boolean multiple) throws IOException;
+
+}

src/main/java/com/rabbitmq/client/Connection.java

@@ -1,4 +1,4 @@
-// Copyright (c) 2007-Present Pivotal Software, Inc.  All rights reserved.
+// Copyright (c) 2007-2017 Pivotal Software, Inc.  All rights reserved.
 //
 // This software, the RabbitMQ Java client library, is triple-licensed under the
 // Mozilla Public License 1.1 ("MPL"), the GNU General Public License version 2
@@ -239,6 +239,8 @@ public interface Connection extends ShutdownNotifier, Closeable { // rename to A
      */
     void addBlockedListener(BlockedListener listener);
 
+    BlockedListener addBlockedListener(BlockedCallback blockedCallback, UnblockedCallback unblockedCallback);
+
     /**
      * Remove a {@link BlockedListener}.
      * @param listener the listener to remove

src/main/java/com/rabbitmq/client/Return.java

@@ -0,0 +1,62 @@
+// Copyright (c) 2007-Present Pivotal Software, Inc.  All rights reserved.
+//
+// This software, the RabbitMQ Java client library, is triple-licensed under the
+// Mozilla Public License 1.1 ("MPL"), the GNU General Public License version 2
+// ("GPL") and the Apache License version 2 ("ASL"). For the MPL, please see
+// LICENSE-MPL-RabbitMQ. For the GPL, please see LICENSE-GPL2.  For the ASL,
+// please see LICENSE-APACHE2.
+//
+// This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND,
+// either express or implied. See the LICENSE file for specific language governing
+// rights and limitations of this software.
+//
+// If you have any questions regarding licensing, please contact us at
+// [email protected].
+
+package com.rabbitmq.client;
+
+/**
+ *
+ */
+public class Return {
+
+    private final int replyCode;
+    private final String replyText;
+    private final String exchange;
+    private final String routingKey;
+    private final AMQP.BasicProperties properties;
+    private final byte[] body;
+
+    public Return(int replyCode, String replyText, String exchange, String routingKey, AMQP.BasicProperties properties, byte[] body) {
+        this.replyCode = replyCode;
+        this.replyText = replyText;
+        this.exchange = exchange;
+        this.routingKey = routingKey;
+        this.properties = properties;
+        this.body = body;
+    }
+
+    public int getReplyCode() {
+        return replyCode;
+    }
+
+    public String getReplyText() {
+        return replyText;
+    }
+
+    public String getExchange() {
+        return exchange;
+    }
+
+    public String getRoutingKey() {
+        return routingKey;
+    }
+
+    public AMQP.BasicProperties getProperties() {
+        return properties;
+    }
+
+    public byte[] getBody() {
+        return body;
+    }
+}

src/main/java/com/rabbitmq/client/ReturnCallback.java

@@ -0,0 +1,25 @@
+// Copyright (c) 2017 Pivotal Software, Inc.  All rights reserved.
+//
+// This software, the RabbitMQ Java client library, is triple-licensed under the
+// Mozilla Public License 1.1 ("MPL"), the GNU General Public License version 2
+// ("GPL") and the Apache License version 2 ("ASL"). For the MPL, please see
+// LICENSE-MPL-RabbitMQ. For the GPL, please see LICENSE-GPL2.  For the ASL,
+// please see LICENSE-APACHE2.
+//
+// This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND,
+// either express or implied. See the LICENSE file for specific language governing
+// rights and limitations of this software.
+//
+// If you have any questions regarding licensing, please contact us at
+// [email protected].
+
+package com.rabbitmq.client;
+
+/**
+ *
+ */
+public interface ReturnCallback {
+
+    void handle(Return returnMessage);
+
+}

src/main/java/com/rabbitmq/client/ShutdownListener.java

@@ -30,5 +30,5 @@
  * @see ShutdownSignalException
  */
 public interface ShutdownListener extends EventListener {
-    public void shutdownCompleted(ShutdownSignalException cause);
+    void shutdownCompleted(ShutdownSignalException cause);
 }

src/main/java/com/rabbitmq/client/ShutdownNotifier.java

@@ -30,26 +30,26 @@ public interface ShutdownNotifier {
      *
      * @param listener {@link ShutdownListener} to the component
      */
-    public void addShutdownListener(ShutdownListener listener);
+    void addShutdownListener(ShutdownListener listener);
 
     /**
      * Remove shutdown listener for the component.
      *
      * @param listener {@link ShutdownListener} to be removed
      */
-    public void removeShutdownListener(ShutdownListener listener);
+    void removeShutdownListener(ShutdownListener listener);
 
     /**
      * Get the shutdown reason object
      * @return ShutdownSignalException if component is closed, null otherwise
      */
-    public ShutdownSignalException getCloseReason();
+    ShutdownSignalException getCloseReason();
 
     /**
      * Protected API - notify the listeners attached to the component
      * @see com.rabbitmq.client.ShutdownListener
      */
-    public void notifyListeners();
+    void notifyListeners();
 
     /**
      * Determine whether the component is currently open.

src/main/java/com/rabbitmq/client/UnblockedCallback.java

@@ -0,0 +1,27 @@
+// Copyright (c) 2017 Pivotal Software, Inc.  All rights reserved.
+//
+// This software, the RabbitMQ Java client library, is triple-licensed under the
+// Mozilla Public License 1.1 ("MPL"), the GNU General Public License version 2
+// ("GPL") and the Apache License version 2 ("ASL"). For the MPL, please see
+// LICENSE-MPL-RabbitMQ. For the GPL, please see LICENSE-GPL2.  For the ASL,
+// please see LICENSE-APACHE2.
+//
+// This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY KIND,
+// either express or implied. See the LICENSE file for specific language governing
+// rights and limitations of this software.
+//
+// If you have any questions regarding licensing, please contact us at
+// [email protected].
+
+package com.rabbitmq.client;
+
+import java.io.IOException;
+
+/**
+ *
+ */
+public interface UnblockedCallback {
+
+    void handle() throws IOException;
+
+}

src/main/java/com/rabbitmq/client/impl/AMQConnection.java

@@ -1031,6 +1031,24 @@ public void addBlockedListener(BlockedListener listener) {
         blockedListeners.add(listener);
     }
 
+    @Override
+    public BlockedListener addBlockedListener(BlockedCallback blockedCallback, UnblockedCallback unblockedCallback) {
+        BlockedListener blockedListener = new BlockedListener() {
+
+            @Override
+            public void handleBlocked(String reason) throws IOException {
+                blockedCallback.handle(reason);
+            }
+
+            @Override
+            public void handleUnblocked() throws IOException {
+                unblockedCallback.handle();
+            }
+        };
+        this.addBlockedListener(blockedListener);
+        return blockedListener;
+    }
+
     @Override
     public boolean removeBlockedListener(BlockedListener listener) {
         return blockedListeners.remove(listener);

src/main/java/com/rabbitmq/client/impl/ChannelN.java

@@ -26,6 +26,7 @@
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeoutException;
 
+import com.rabbitmq.client.ConfirmCallback;
 import com.rabbitmq.client.*;
 import com.rabbitmq.client.AMQP.BasicProperties;
 import com.rabbitmq.client.Method;
@@ -135,6 +136,15 @@ public void addReturnListener(ReturnListener listener) {
         returnListeners.add(listener);
     }
 
+    @Override
+    public ReturnListener addReturnListener(ReturnCallback returnCallback) {
+        ReturnListener returnListener = (replyCode, replyText, exchange, routingKey, properties, body) -> returnCallback.handle(new Return(
+            replyCode, replyText, exchange, routingKey, properties, body
+        ));
+        this.addReturnListener(returnListener);
+        return returnListener;
+    }
+
     @Override
     public boolean removeReturnListener(ReturnListener listener) {
         return returnListeners.remove(listener);
@@ -150,6 +160,24 @@ public void addConfirmListener(ConfirmListener listener) {
         confirmListeners.add(listener);
     }
 
+    @Override
+    public ConfirmListener addConfirmListener(ConfirmCallback ackCallback, ConfirmCallback nackCallback) {
+        ConfirmListener confirmListener = new ConfirmListener() {
+
+            @Override
+            public void handleAck(long deliveryTag, boolean multiple) throws IOException {
+                ackCallback.handle(deliveryTag, multiple);
+            }
+
+            @Override
+            public void handleNack(long deliveryTag, boolean multiple) throws IOException {
+                nackCallback.handle(deliveryTag, multiple);
+            }
+        };
+        this.addConfirmListener(confirmListener);
+        return confirmListener;
+    }
+
     @Override
     public boolean removeConfirmListener(ConfirmListener listener) {
         return confirmListeners.remove(listener);

src/main/java/com/rabbitmq/client/impl/recovery/AutorecoveringChannel.java

@@ -98,6 +98,15 @@ public void addReturnListener(ReturnListener listener) {
         delegate.addReturnListener(listener);
     }
 
+    @Override
+    public ReturnListener addReturnListener(ReturnCallback returnCallback) {
+        ReturnListener returnListener = (replyCode, replyText, exchange, routingKey, properties, body) -> returnCallback.handle(new Return(
+            replyCode, replyText, exchange, routingKey, properties, body
+        ));
+        this.addReturnListener(returnListener);
+        return returnListener;
+    }
+
     @Override
     public boolean removeReturnListener(ReturnListener listener) {
         this.returnListeners.remove(listener);
@@ -116,6 +125,24 @@ public void addConfirmListener(ConfirmListener listener) {
         delegate.addConfirmListener(listener);
     }
 
+    @Override
+    public ConfirmListener addConfirmListener(ConfirmCallback ackCallback, ConfirmCallback nackCallback) {
+        ConfirmListener confirmListener = new ConfirmListener() {
+
+            @Override
+            public void handleAck(long deliveryTag, boolean multiple) throws IOException {
+                ackCallback.handle(deliveryTag, multiple);
+            }
+
+            @Override
+            public void handleNack(long deliveryTag, boolean multiple) throws IOException {
+                nackCallback.handle(deliveryTag, multiple);
+            }
+        };
+        this.addConfirmListener(confirmListener);
+        return confirmListener;
+    }
+
     @Override
     public boolean removeConfirmListener(ConfirmListener listener) {
         this.confirmListeners.remove(listener);

src/main/java/com/rabbitmq/client/impl/recovery/AutorecoveringConnection.java

@@ -306,6 +306,24 @@ public void addBlockedListener(BlockedListener listener) {
         delegate.addBlockedListener(listener);
     }
 
+    @Override
+    public BlockedListener addBlockedListener(BlockedCallback blockedCallback, UnblockedCallback unblockedCallback) {
+        BlockedListener blockedListener = new BlockedListener() {
+
+            @Override
+            public void handleBlocked(String reason) throws IOException {
+                blockedCallback.handle(reason);
+            }
+
+            @Override
+            public void handleUnblocked() throws IOException {
+                unblockedCallback.handle();
+            }
+        };
+        this.addBlockedListener(blockedListener);
+        return blockedListener;
+    }
+
     /**
      * @see Connection#removeBlockedListener(com.rabbitmq.client.BlockedListener)
      */