Skip to content

Commit d317c9a

Browse files
acogoluegnesacogoluegnes
committed
Clean pom.xml
Use properties for all dependencies and plugins. Remove some duplicated declaration. Upgrade Javadoc plugin to 3.0.0-M1 to make build work on JDK 9.
1 parent 3e9ff94 commit d317c9a

File tree

1 file changed

+56
-72
lines changed

1 file changed

+56
-72
lines changed

‎pom.xml

Lines changed: 56 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,23 @@
6262
<awaitility.version>2.0.0</awaitility.version>
6363
<mockito.version>2.7.9</mockito.version>
6464

65+
<maven.javadoc.plugin.version>3.0.0-M1</maven.javadoc.plugin.version>
66+
<maven.release.plugin.version>2.5.3</maven.release.plugin.version>
67+
<versions.maven.plugin.version>2.3</versions.maven.plugin.version>
68+
<maven.resources.plugin.version>3.0.1</maven.resources.plugin.version>
69+
<maven.sources.plugin.version>3.0.1</maven.sources.plugin.version>
70+
<groovy.maven.plugin.version>2.0</groovy.maven.plugin.version>
71+
<groovy.all.version>2.4.8</groovy.all.version>
72+
<nexus-staging-maven-plugin.version>1.6.8</nexus-staging-maven-plugin.version>
73+
<keytool.maven.plugin.version>1.5</keytool.maven.plugin.version>
74+
<build.helper.maven-plugin.version>1.12</build.helper.maven-plugin.version>
75+
<maven.compiler.plugin.version>3.5.1</maven.compiler.plugin.version>
76+
<maven.surefire.plugin.version>2.19.1</maven.surefire.plugin.version>
77+
<maven.failsafe.plugin.version>2.19.1</maven.failsafe.plugin.version>
78+
<maven.gpg.plugin.version>1.6</maven.gpg.plugin.version>
79+
<maven.jar.plugin.version>3.0.2</maven.jar.plugin.version>
80+
<maven.bundle.plugin.version>2.3.7</maven.bundle.plugin.version>
81+
6582
<!--
6683
These groovy scripts are used later in this POM file to generate
6784
source files and resources for the library itself and for the
@@ -102,7 +119,6 @@
102119

103120
<!-- to sign artifacts when releasing -->
104121
<gpg.keyname>6026DFCA</gpg.keyname>
105-
<nexus-staging-maven-plugin.version>1.6.8</nexus-staging-maven-plugin.version>
106122
</properties>
107123

108124
<profiles>
@@ -185,12 +201,12 @@
185201
<plugin>
186202
<groupId>org.codehaus.gmaven</groupId>
187203
<artifactId>groovy-maven-plugin</artifactId>
188-
<version>2.0</version>
204+
<version>${groovy.maven.plugin.version}</version>
189205
<dependencies>
190206
<dependency>
191207
<groupId>org.codehaus.groovy</groupId>
192208
<artifactId>groovy-all</artifactId>
193-
<version>2.4.8</version>
209+
<version>${groovy.all.version}</version>
194210
</dependency>
195211
</dependencies>
196212
<executions>
@@ -312,6 +328,7 @@
312328
<plugin>
313329
<groupId>org.codehaus.mojo</groupId>
314330
<artifactId>keytool-maven-plugin</artifactId>
331+
<version>${keytool.maven.plugin.version}</version>
315332
<configuration>
316333
<skip>false</skip>
317334
</configuration>
@@ -340,6 +357,7 @@
340357
<plugin>
341358
<groupId>org.codehaus.mojo</groupId>
342359
<artifactId>keytool-maven-plugin</artifactId>
360+
<version>${keytool.maven.plugin.version}</version>
343361
<configuration>
344362
<skip>false</skip>
345363
</configuration>
@@ -371,7 +389,7 @@
371389
<plugin>
372390
<groupId>org.apache.maven.plugins</groupId>
373391
<artifactId>maven-failsafe-plugin</artifactId>
374-
<version>2.19.1</version>
392+
<version>${maven.failsafe.plugin.version}</version>
375393
<configuration>
376394
<systemPropertyVariables>
377395
<make.bin>${make.bin}</make.bin>
@@ -433,7 +451,7 @@
433451
<plugin>
434452
<groupId>org.apache.maven.plugins</groupId>
435453
<artifactId>maven-failsafe-plugin</artifactId>
436-
<version>2.19.1</version>
454+
<version>${maven.failsafe.plugin.version}</version>
437455
<configuration>
438456
<systemPropertyVariables>
439457
<use.nio>true</use.nio>
@@ -452,34 +470,13 @@
452470
<id>ossrh-release</id>
453471
<build>
454472
<plugins>
455-
<plugin>
456-
<groupId>org.sonatype.plugins</groupId>
457-
<artifactId>nexus-staging-maven-plugin</artifactId>
458-
<version>${nexus-staging-maven-plugin.version}</version>
459-
<configuration>
460-
<serverId>ossrh</serverId>
461-
<nexusUrl>https://oss.sonatype.org/</nexusUrl>
462-
<skipStaging>false</skipStaging>
463-
</configuration>
464-
</plugin>
465-
<plugin>
466-
<groupId>org.apache.maven.plugins</groupId>
467-
<artifactId>maven-source-plugin</artifactId>
468-
<version>3.0.1</version>
469-
<executions>
470-
<execution>
471-
<goals>
472-
<goal>jar</goal>
473-
</goals>
474-
</execution>
475-
</executions>
476-
</plugin>
477473
<plugin>
478474
<groupId>org.apache.maven.plugins</groupId>
479475
<artifactId>maven-javadoc-plugin</artifactId>
480-
<version>2.10.4</version>
476+
<version>${maven.javadoc.plugin.version}</version>
481477
<configuration>
482478
<additionalparam>${javadoc.opts}</additionalparam>
479+
<quiet>true</quiet>
483480
</configuration>
484481
<executions>
485482
<execution>
@@ -493,7 +490,7 @@
493490
<plugin>
494491
<groupId>org.apache.maven.plugins</groupId>
495492
<artifactId>maven-gpg-plugin</artifactId>
496-
<version>1.6</version>
493+
<version>${maven.gpg.plugin.version}</version>
497494
<executions>
498495
<execution>
499496
<id>sign-artifacts</id>
@@ -514,10 +511,6 @@
514511
<id>ossrh</id>
515512
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
516513
</snapshotRepository>
517-
<repository>
518-
<id>ossrh</id>
519-
<url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url>
520-
</repository>
521514
</distributionManagement>
522515
</profile>
523516

@@ -529,24 +522,13 @@
529522
<id>bintray-release</id>
530523
<build>
531524
<plugins>
532-
<plugin>
533-
<groupId>org.apache.maven.plugins</groupId>
534-
<artifactId>maven-source-plugin</artifactId>
535-
<version>3.0.1</version>
536-
<executions>
537-
<execution>
538-
<goals>
539-
<goal>jar</goal>
540-
</goals>
541-
</execution>
542-
</executions>
543-
</plugin>
544525
<plugin>
545526
<groupId>org.apache.maven.plugins</groupId>
546527
<artifactId>maven-javadoc-plugin</artifactId>
547-
<version>2.10.4</version>
528+
<version>${maven.javadoc.plugin.version}</version>
548529
<configuration>
549530
<additionalparam>${javadoc.opts}</additionalparam>
531+
<quiet>true</quiet>
550532
</configuration>
551533
<executions>
552534
<execution>
@@ -560,7 +542,7 @@
560542
<plugin>
561543
<groupId>org.apache.maven.plugins</groupId>
562544
<artifactId>maven-gpg-plugin</artifactId>
563-
<version>1.6</version>
545+
<version>${maven.gpg.plugin.version}</version>
564546
<executions>
565547
<execution>
566548
<id>sign-artifacts</id>
@@ -593,24 +575,13 @@
593575
<id>milestone</id>
594576
<build>
595577
<plugins>
596-
<plugin>
597-
<groupId>org.apache.maven.plugins</groupId>
598-
<artifactId>maven-source-plugin</artifactId>
599-
<version>3.0.1</version>
600-
<executions>
601-
<execution>
602-
<goals>
603-
<goal>jar</goal>
604-
</goals>
605-
</execution>
606-
</executions>
607-
</plugin>
608578
<plugin>
609579
<groupId>org.apache.maven.plugins</groupId>
610580
<artifactId>maven-javadoc-plugin</artifactId>
611-
<version>2.10.4</version>
581+
<version>${maven.javadoc.plugin.version}</version>
612582
<configuration>
613583
<additionalparam>${javadoc.opts}</additionalparam>
584+
<quiet>true</quiet>
614585
</configuration>
615586
<executions>
616587
<execution>
@@ -624,7 +595,7 @@
624595
<plugin>
625596
<groupId>org.apache.maven.plugins</groupId>
626597
<artifactId>maven-gpg-plugin</artifactId>
627-
<version>1.6</version>
598+
<version>${maven.gpg.plugin.version}</version>
628599
<executions>
629600
<execution>
630601
<id>sign-artifacts</id>
@@ -719,17 +690,17 @@
719690
<plugin>
720691
<groupId>org.apache.maven.plugins</groupId>
721692
<artifactId>maven-resources-plugin</artifactId>
722-
<version>3.0.1</version>
693+
<version>${maven.sources.plugin.version}</version>
723694
</plugin>
724695
<plugin>
725696
<groupId>org.codehaus.gmaven</groupId>
726697
<artifactId>groovy-maven-plugin</artifactId>
727-
<version>2.0</version>
698+
<version>${groovy.maven.plugin.version}</version>
728699
<dependencies>
729700
<dependency>
730701
<groupId>org.codehaus.groovy</groupId>
731702
<artifactId>groovy-all</artifactId>
732-
<version>2.4.8</version>
703+
<version>${groovy.all.version}</version>
733704
</dependency>
734705
</dependencies>
735706
<executions>
@@ -787,7 +758,7 @@
787758
<plugin>
788759
<groupId>org.codehaus.mojo</groupId>
789760
<artifactId>build-helper-maven-plugin</artifactId>
790-
<version>1.12</version>
761+
<version>${build.helper.maven-plugin.version}</version>
791762
<executions>
792763
<execution>
793764
<id>add-generated-sources-dir</id>
@@ -806,7 +777,7 @@
806777

807778
<plugin>
808779
<artifactId>maven-compiler-plugin</artifactId>
809-
<version>3.5.1</version>
780+
<version>${maven.compiler.plugin.version}</version>
810781
<configuration>
811782
<source>1.6</source>
812783
<target>1.6</target>
@@ -824,7 +795,7 @@
824795
<plugin>
825796
<groupId>org.apache.maven.plugins</groupId>
826797
<artifactId>maven-surefire-plugin</artifactId>
827-
<version>2.19.1</version>
798+
<version>${maven.surefire.plugin.version}</version>
828799
<configuration>
829800
<skip>true</skip>
830801
</configuration>
@@ -834,7 +805,7 @@
834805
<plugin>
835806
<groupId>org.codehaus.mojo</groupId>
836807
<artifactId>keytool-maven-plugin</artifactId>
837-
<version>1.5</version>
808+
<version>${keytool.maven.plugin.version}</version>
838809
<configuration>
839810
<skip>true</skip>
840811
</configuration>
@@ -874,7 +845,7 @@
874845
<plugin>
875846
<groupId>org.apache.maven.plugins</groupId>
876847
<artifactId>maven-jar-plugin</artifactId>
877-
<version>3.0.2</version>
848+
<version>${maven.jar.plugin.version}</version>
878849
<configuration>
879850
<archive>
880851
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
@@ -885,7 +856,7 @@
885856
<plugin>
886857
<groupId>org.apache.felix</groupId>
887858
<artifactId>maven-bundle-plugin</artifactId>
888-
<version>2.3.7</version>
859+
<version>${maven.bundle.plugin.version}</version>
889860
<executions>
890861
<execution>
891862
<id>bundle-manifest</id>
@@ -913,18 +884,31 @@
913884
<plugin>
914885
<groupId>org.codehaus.mojo</groupId>
915886
<artifactId>versions-maven-plugin</artifactId>
916-
<version>2.3</version>
887+
<version>${versions.maven.plugin.version}</version>
917888
</plugin>
918889

919890
<plugin>
920891
<groupId>org.apache.maven.plugins</groupId>
921892
<artifactId>maven-release-plugin</artifactId>
922-
<version>2.5.3</version>
893+
<version>${maven.release.plugin.version}</version>
923894
<configuration>
924895
<tagNameFormat>v@{project.version}</tagNameFormat>
925896
</configuration>
926897
</plugin>
927898

899+
<plugin>
900+
<groupId>org.apache.maven.plugins</groupId>
901+
<artifactId>maven-source-plugin</artifactId>
902+
<version>${maven.sources.plugin.version}</version>
903+
<executions>
904+
<execution>
905+
<goals>
906+
<goal>jar</goal>
907+
</goals>
908+
</execution>
909+
</executions>
910+
</plugin>
911+
928912
</plugins>
929913
</build>
930914

0 commit comments

Comments
 (0)